Add 1D option to ignore 2D functionality #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gregordecristoforo I just made an additional commit now to multiply the array of ones by the free parameter in the blob factories. It is something I need to have a degenerate distribution with value other than 1 (as I can see, there is no other way to do that now) |
gregordecristoforo
approved these changes
Oct 5, 2022
|
Seems fine to me, we should also change the test https://github.com/uit-cosmo/2d-propagating-blobs/blob/main/tests/test_analytical.py which isn't adapted to the 1D option yet. I can take a look at that tomorrow. |
|
hmm, why should it be changed? I thought it was a 2d test? I added a new analytical test, which is just this one adapted to 1d. |
|
This test was originally intended as a 1D case. Sorry I missed you already implemented the new test in 1D. Don't mind my previous comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we discussed in Slack. Please check if it is necessary to add 1d checks in other parts of the code that I might have missed.