Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Commencement] Skip deleting imported events #8359

Merged
merged 2 commits into from
Dec 23, 2024
Merged

[Commencement] Skip deleting imported events #8359

merged 2 commits into from
Dec 23, 2024

Conversation

pyrello
Copy link
Contributor

@pyrello pyrello commented Dec 23, 2024

Related to #8358

How to test

  • Check that this resolves the issue with events being deleted on the commencement site.
  • Check that this change does not prevent other importers from deleting imported content. Spot checking (vs checking every importer) is fine.

@pyrello pyrello requested a review from cory-skeers December 23, 2024 16:51
@cory-skeers cory-skeers self-assigned this Dec 23, 2024
@pyrello pyrello mentioned this pull request Dec 23, 2024
Closed
@cory-skeers
Copy link
Contributor

Tested locally on facilities with an extra building added, and it was deleted as expected.
image
Testing locally on commencement, on main 3 events are deleted and (after re-syncing) on this branch 0 are deleted.
image

cory-skeers
cory-skeers approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@cory-skeers cory-skeers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and spot tested, and works well for both the default deletion and overridden skipDelete options.

@cory-skeers cory-skeers removed their assignment Dec 23, 2024
@pyrello pyrello merged commit 5a39612 into main Dec 23, 2024
2 checks passed
@pyrello pyrello deleted the commencement_skip_deleting_imported_events branch December 23, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cory-skeers cory-skeers cory-skeers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyrello @cory-skeers