Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the complication of entity view display config storage #6271

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

pyrello
Copy link
Contributor

@pyrello pyrello commented Mar 17, 2023

Motivation

Entity view display config has an option to store region information about about where fields should be placed. It is part of an old system of page generation that we don't really use with our move to Layout Builder. The information stored in that part of the config has no functional impact (to the best of my knowledge) on how our platform works. It is an artifact of how Drupal is initially set up, when fields are set in a region list. Unless you update the config at that point to move all the fields to "hidden" it gets frozen at whatever state it was in when you turn on Layout Builder. You no longer have access to the form to update that config.

The PR proposes a method for not storing the unnecessary config and making its non-storage into a systematic change that will automatically be reflected in the way that the configuration is output anytime it is re-saved.

The benefit of doing this is that we can shrink the file sizes for these config significantly and not have the noise to contend with when we are looking for actual useful information in the config.

How to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant