fix: reflection of chime duration seconds

[bdraco]

Description of change

The mocking in the test was using an int instead
of a timedelta. Add new property to
get the seconds

Summary by CodeRabbit

• New Features

  • Added chime_duration_seconds property to the Camera class for easier retrieval of chime duration in seconds.

• Improvements

  • Enhanced chime_type property in the Camera class to use a new function for determining ChimeType based on total seconds.
  • Introduced timedelta_total_seconds function for more accurate time calculations.

• Bug Fixes

  • Updated test cases to use proper timedelta values, ensuring more robust and accurate testing.

[coderabbitai]

Warning

Review failed

The pull request is closed.

Walkthrough

The update enhances the functionality of the Camera class by adding new utility functions and properties. The chime_type property logic is refactored into a new function _chime_type_from_total_seconds, and a helper function timedelta_total_seconds is introduced. Additionally, a new property chime_duration_seconds is added to easily access the total seconds of the chime duration. Tests are updated accordingly to accommodate these changes.

Changes

File	Change Summary
src/uiprotect/data/devices.py	Updated import to include functools.lru_cache and added _chime_type_from_total_seconds and chime_duration_seconds-specific properties.
src/uiprotect/utils.py	Added timedelta_total_seconds function with @lru_cache decorator.
tests/data/test_camera.py	Adjusted test to initialize chime_duration with timedelta and added assertion for chime_duration_seconds.

Poem

In the code, a rabbit’s touch,
Functions tweaked, but not too much.
Chimes now follow newfound rhyme,
Seconds counted, keeping time.
Tests are bright, like summer’s lit,
Coding marvels bit by bit.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.