Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.6.10) - SB3 release and sphinx multiversion fix #459

Merged
merged 9 commits into from
Nov 18, 2024

Conversation

AlejandroCN7
Copy link
Member

Description

This update makes Sinergym work with the latest SB3 release instead of the master branch, as they have included compatibility with gymnasium v1.0. They have not yet brought support for the latest versions of Torch and numpy v2.0. However, these updates will come in the future (we decided to delay the update of these packages in order to keep SB3 compatible with Sinergym).
On the other hand, this update includes some minor changes to the tool. The sphinx-multiversion issue has been fixed so that the documentation works again. In addition, a bug with package detection has been fixed so that SB3 tests can be relaunched normally. For more information visit the changelog.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Environment: delete coverage for empty queues in reset, delete test.
  • Fix: Stable Baselines 3 package detection for tests.
  • Fix multiversion documentation: using mock for gymnasium.wrappers.normalize.
  • Poetry: Using latest SB3 version as optional, including mock package for developing group.

@AlejandroCN7 AlejandroCN7 merged commit f91a68f into main Nov 18, 2024
6 checks passed
@AlejandroCN7 AlejandroCN7 deleted the supp/versions-update branch November 18, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant