Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert iovr=4 (exponential cloud overlap method) in RRTMG #963

Merged
merged 14 commits into from
Dec 28, 2021
Merged
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[submodule "FV3"]
path = FV3
url = https://github.com/NOAA-EMC/fv3atm
branch = develop
url = https://github.com/mzhangw/fv3atm
branch = revert_iovr4
[submodule "WW3"]
path = WW3
url = https://github.com/NOAA-EMC/WW3
2 changes: 1 addition & 1 deletion FV3
1,071 changes: 442 additions & 629 deletions tests/RegressionTests_gaea.intel.log

Large diffs are not rendered by default.

498 changes: 160 additions & 338 deletions tests/RegressionTests_hera.gnu.log

Large diffs are not rendered by default.

1,089 changes: 450 additions & 639 deletions tests/RegressionTests_hera.intel.log

Large diffs are not rendered by default.

1,007 changes: 409 additions & 598 deletions tests/RegressionTests_jet.intel.log

Large diffs are not rendered by default.

1,099 changes: 461 additions & 638 deletions tests/RegressionTests_orion.intel.log

Large diffs are not rendered by default.

755 changes: 283 additions & 472 deletions tests/RegressionTests_wcoss_cray.log

Large diffs are not rendered by default.

1,091 changes: 451 additions & 640 deletions tests/RegressionTests_wcoss_dell_p3.log

Large diffs are not rendered by default.

32 changes: 0 additions & 32 deletions tests/fv3_conf/c96_HAFS_v0_hwrf_run.IN

This file was deleted.

9 changes: 0 additions & 9 deletions tests/fv3_conf/esg_HAFS_v0_hwrf_run.IN

This file was deleted.

274 changes: 0 additions & 274 deletions tests/parm/c96_HAFS_v0_hwrf.nml.IN

This file was deleted.

35 changes: 0 additions & 35 deletions tests/parm/esg_HAFS_v0_hwrf-model_configure.IN

This file was deleted.

288 changes: 0 additions & 288 deletions tests/parm/esg_HAFS_v0_hwrf.nml.IN

This file was deleted.

9 changes: 1 addition & 8 deletions tests/rt.conf
Original file line number Diff line number Diff line change
@@ -78,7 +78,7 @@ RUN | rap_sfcdiff_restart
RUN | hrrr_control | | fv3 |
RUN | rrfs_v1beta | | fv3 |

COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_GFS_v16_RRTMGP,FV3_GFS_v16_csawmg,FV3_GFS_v16_flake,FV3_GFS_v16_ugwpv1,FV3_GFS_v16_ras,FV3_GFS_v16_thompson,FV3_GFS_v16_noahmp,FV3_HAFS_v0_hwrf_thompson | | fv3 |
COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_GFS_v16_RRTMGP,FV3_GFS_v16_csawmg,FV3_GFS_v16_flake,FV3_GFS_v16_ugwpv1,FV3_GFS_v16_ras,FV3_GFS_v16_thompson,FV3_GFS_v16_noahmp | | fv3 |
# fv3_gfs_v15p2 and fv3_gfs_v15p2_RRTMGP fail w/ sat.vap pressure error when cdmbgwd=0.14,1.8,1.0,1.0
RUN | control_rrtmgp | | fv3 |
#RUN | control_rrtmgp_2threads | | |
@@ -91,9 +91,6 @@ RUN | control_ras
RUN | control_thompson | - wcoss_cray | fv3 |
RUN | control_thompson_no_aero | - wcoss_cray | fv3 |

RUN | fv3_HAFS_v0_hwrf_thompson | | fv3 |
RUN | fv3_esg_HAFS_v0_hwrf_thompson | | fv3 |

# Run WAM test in REPRO mode to avoid numerical instability in the deep atmosphere
COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_GFS_v16_fv3wam -D32BIT=ON -DMULTI_GASES=ON -DREPRO=ON | | fv3 |
RUN | control_wam | | fv3 |
@@ -138,10 +135,6 @@ RUN | rap_flake_debug
RUN | rap_noah_sfcdiff_cires_ugwp_debug | | fv3 |
RUN | rrfs_v1beta_debug | | fv3 |

COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_HAFS_v0_hwrf_thompson -DDEBUG=ON | | fv3 |
RUN | fv3_HAFS_v0_hwrf_thompson_debug | | fv3 |
RUN | fv3_esg_HAFS_v0_hwrf_thompson_debug | -cheyenne.intel | fv3 |

###################################################################################################################################################################################
# HAFS tests #
###################################################################################################################################################################################
9 changes: 1 addition & 8 deletions tests/rt_gnu.conf
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
# CCPP PROD tests #
##################################################################################################################################################################

COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_GFS_v16,FV3_GFS_v16_flake,FV3_GFS_v16_RRTMGP,FV3_GFS_v16_thompson,FV3_GFS_v16_ras,FV3_HAFS_v0_hwrf_thompson,FV3_GFS_v16_nsstNoahmpUGWPv1 | | fv3 |
COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_GFS_v16,FV3_GFS_v16_flake,FV3_GFS_v16_RRTMGP,FV3_GFS_v16_thompson,FV3_GFS_v16_ras,FV3_GFS_v16_nsstNoahmpUGWPv1 | | fv3 |

RUN | control | | fv3 |
RUN | control_restart | | | control
@@ -15,9 +15,6 @@ RUN | control_thompson_no_aero
RUN | control_ras | | fv3 |
RUN | control_p7 | | fv3 |

RUN | fv3_HAFS_v0_hwrf_thompson | | fv3 |
RUN | fv3_esg_HAFS_v0_hwrf_thompson | | fv3 |

COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_RAP_sfcdiff,FV3_HRRR,FV3_RRFS_v1beta -D32BIT=ON | | fv3 |

RUN | rap_control | | fv3 |
@@ -58,10 +55,6 @@ RUN | control_ras_debug
RUN | control_stochy_debug | | fv3 |
RUN | control_debug_p7 | | fv3 |

COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_HAFS_v0_hwrf_thompson -DDEBUG=ON | | fv3 |
RUN | fv3_HAFS_v0_hwrf_thompson_debug | | fv3 |
RUN | fv3_esg_HAFS_v0_hwrf_thompson_debug | | fv3 |

#COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_GFS_2017_fv3wam -D32BIT=ON -DMULTI_GASES=ON -DDEBUG=ON | | fv3 |
#RUN | fv3_multigases_debug | | fv3 |

112 changes: 0 additions & 112 deletions tests/tests/fv3_HAFS_v0_hwrf_thompson

This file was deleted.

115 changes: 0 additions & 115 deletions tests/tests/fv3_HAFS_v0_hwrf_thompson_debug

This file was deleted.

65 changes: 0 additions & 65 deletions tests/tests/fv3_esg_HAFS_v0_hwrf_thompson

This file was deleted.

65 changes: 0 additions & 65 deletions tests/tests/fv3_esg_HAFS_v0_hwrf_thompson_debug

This file was deleted.