Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with upp/10.0.9 and turn on inline post rt tests in debug mode. #773

Merged
merged 33 commits into from
Sep 13, 2021

Conversation

WenMeng-NOAA
Copy link
Contributor

@WenMeng-NOAA WenMeng-NOAA commented Aug 26, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

  • Update upp lib to 10.0.9.
  • Update UPP control file for RRFS inline post.
  • Turn on inline post in control_debug test.
  • Add regional_quilt_debug test which includes inline post.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

Dependencies

None

@junwang-noaa junwang-noaa added Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Sep 8, 2021
@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Sep 8, 2021 via email

@WenMeng-NOAA
Copy link
Contributor Author

@junwang-noaa Added the inline post comparison in control_debug. Thanks!

@MinsukJi-NOAA
Copy link
Contributor

@WenMeng-NOAA can you please make changes in two files for CI container library update to upp 10.0.9?

diff --git a/tests/ci/Dockerfile b/tests/ci/Dockerfile
index 34feec3..3534560 100644
--- a/tests/ci/Dockerfile
+++ b/tests/ci/Dockerfile
@@ -1,4 +1,4 @@
-From noaaemc/ubuntu-hpc:v1.6b
+From noaaemc/ubuntu-hpc:v1.7b
 
 ENV HOME=/home/builder
 COPY --chown=builder:builder . $HOME/ufs-weather-model

diff --git a/tests/ci/ci.sh b/tests/ci/ci.sh
index 7702ed3..05f0bed 100755
--- a/tests/ci/ci.sh
+++ b/tests/ci/ci.sh
@@ -81,7 +81,7 @@ elif [ $RUN == "true" ]; then
                 -e "RT_MACHINE=linux.gnu" -e "RT_COMPILER=gnu" \
                 -w "/home/builder/ufs-weather-model/tests" \
                 -v DataVolume:/home/builder/data/NEMSfv3gfs/input-data-20210528 \
-                --shm-size=512m --name my-container noaaemc/ubuntu-hpc:v1.6b \
+                --shm-size=512m --name my-container noaaemc/ubuntu-hpc:v1.7b \
                 /bin/bash -c "./utest -n ${TEST_NAME} -c ${TEST_CASE} -x"
 
   cd $GITHUB_WORKSPACE

@WenMeng-NOAA
Copy link
Contributor Author

@MinsukJi-NOAA The changes for CI container were committed. Thanks!

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: RT
Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/720601014/20210911000036/ufs-weather-model
Please manually delete: /scratch1/NCEPDEV/stmp2/emc.nemspara/FV3_RT/rt_16922
Test control_csawmg 036 failed failed
Test control_csawmg 036 failed in run_test failed
Please make changes and add the following label back:
hera-intel-RT

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: gaea
Compiler: intel
Job: RT
Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/720601014/20210912033005/ufs-weather-model
Please manually delete: /lustre/f2/scratch/emc.nemspara/FV3_RT/rt_21140
Test cpld_bmark_wave_v16 013 failed failed
Test cpld_bmark_wave_v16 013 failed in run_test failed
Test cpld_bmark_v16_nsst 012 failed failed
Test cpld_bmark_v16_nsst 012 failed in run_test failed
Test hafs_regional_atm 084 failed failed
Test hafs_regional_atm 084 failed in run_test failed
Please make changes and add the following label back:
gaea-intel-RT

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: BL
Repo location: /glade/scratch/dtcufsrt/autort/tests/auto/pr/720601014/20210913054510/ufs-weather-model
/glade/p/ral/jntp/GMTB/ufs-weather-model/RT/NEMSfv3gfs/develop-20210907/INTEL
Exists already. It should not yet. Please delete.
Please make changes and add the following label back:
cheyenne-intel-BL

@junwang-noaa junwang-noaa merged commit bbdd167 into ufs-community:develop Sep 13, 2021
uturuncoglu added a commit to uturuncoglu/ufs-weather-model that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WRITE_DOPOST error when running in debug mode
7 participants