Add extended diagnostic output from Thompson MP + regression test, includes "Add optional scaling to RRTMGP flux adjustment" (#605), bug fix in several suite definition files

[climbfuji]

PR Checklist

• Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

• This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

• An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
  are specified below.

• If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

This PR contains the following changes:

• Update submodule pointer for fv3atm and ccpp-physics for adding extended diagnostic output from Thompson MP
• Add a new regression test that exercises this capability
• Adjust the formatting in rt.conf and rt_gnu.conf so that the tables align

A new diag_table is required for the new test, this file can be added to the existing input data directory.

Note. Because of the code changes in Thompson MP, the regression tests using Thompson with Intel in PROD mode change results (an optimization difference). With Intel in DEBUG mode, as well as with GNU in PROD and DEBUG mode, the results for the Thompson MP runs are identical.

This PR includes the changes in #605, "Add optional scaling to RRTMGP flux adjustment" - these will require an update of the RRTMGP baselines.

The associated fv3atm PR also includes bugfixes to several suite definition files (add missing calls to GFS_radiation_surface) that will change the answer of the regression tests using those suites.

Issue(s) addressed

Fixes NCAR/ccpp-physics#680.

Testing

Initial testing

1. Create new baselines for the following tests, then verify against them on Hera using GNU and Intel: all tests pass.

control_thompson_debug
control_thompson_no_aero_debug
control_thompson_extdiag_debug (new test)

rt_min_hera_gnu_create.log
rt_min_hera_gnu_verify.log
rt_min_hera_intel_create.log
rt_min_hera_intel_verify.log

2. Verify against existing baselines on Hera using GNU and Intel: Because of the code changes in Thompson MP, the regression tests using Thompson with Intel in PROD mode change results (an optimization difference). With Intel in DEBUG mode, as well as with GNU in PROD and DEBUG mode, the results for the Thompson MP runs are identical. All other regression tests are b4b identical.

Second regression testing (after merging in RRTMGP flux adjustment, fixing suite definition file bugs)

Verify against existing baselines on Hera using GNU and Intel: Because of the code changes in Thompson MP, RRTMGP and the suite definition file bugfixes, the following regression tests fail (because of b4b differences or missing baselines, they all run to completion):

With Intel:

control_thompson_extdiag_debug
control_rrtmgp_debug          
fv3_rrfs_v1alpha_debug        
control_rrtmgp                
control_thompson              
control_thompson_no_aero      
fv3_rrfs_v1alpha              
fv3_gsd                       
fv3_HAFS_v0_hwrf_thompson     
fv3_esg_HAFS_v0_hwrf_thompson 
regional_quilt_RRTMGP         
cpld_bmark_wave_v16_noahmp    

rt_hera_intel_verify_against_existing.log
rt_hera_intel_verify_against_existing_fail_test.log

With GNU:

control_thompson_debug        
control_thompson_extdiag_debug
control_rrtmgp_debug          
control_rrtmgp                

rt_hera_gnu_verify_against_existing.log
rt_hera_gnu_verify_against_existing_fail_test.log

Final regression testing (at commit time)

NOT YET APPLICABLE

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

• hera.intel
• hera.gnu
• orion.intel
• cheyenne.intel
• cheyenne.gnu
• gaea.intel
• jet.intel
• wcoss_cray
• wcoss_dell_p3
• CI

Dependencies

NCAR/ccpp-physics#679
NOAA-EMC/fv3atm#331
#658

[climbfuji]

This change is temporary until the new file diag_table_gfsv16_thompson_extdiag has been added to the input data directory.

[ericaligo-NOAA]

With the 3D Thompson diagnostics reset by avg_max_length, all changes look good.

[climbfuji]

This PR was merged as part of #619, including reverting the temporary change to the run scripts and adding the new diag_table for the extended Thompson microphysics run to the input data.