Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global_control.nml.IN based on GW specs #2528

Closed

Conversation

dpsarmie
Copy link
Collaborator

@dpsarmie dpsarmie commented Dec 4, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This commit will add more modifications to global_control.nml.IN and default_vars.sh based on ongoing discussions with the Global Workflow group (NOAA-EMC/global-workflow#3017). These changes remove some of the HIDE strings in the namelist.

The control_c48_lnd_iau regression test namelist and test were also modified to allow the test to remain the same. This test can be ported over to the global_control.nml.IN template. Currently, doing so will cause a change in baselines so I modified the test to keep the baselines consistent.
Changes to cpld_debug_pdlib_p8 were also made to keep the test configs consistent with the cpld_control_pdlib case. Again, no baseline changes are occurring. This is mostly just cleaning up some clutter in the configs.

Commit Message:

* UFSWM - Make additional changes to global_control.nml.IN based on GW needs

Priority:

  • Normal

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@dpsarmie dpsarmie added the No Baseline Change No Baseline Change label Dec 5, 2024
NickSzapiro-NOAA added a commit to NickSzapiro-NOAA/ufs-weather-model that referenced this pull request Dec 12, 2024
FernandoAndrade-NOAA pushed a commit that referenced this pull request Dec 16, 2024
… on GW specs (#2528) + Sync with ESCOMP/CMEPS (#2469)

* UFSWM - Sync with ESCOMP/CDEPS (2024-12).  Sync with ESCOMP/CMEPS (2024-12). Make additional changes to global_control.nml.IN based on GW needs. 
  * CDEPS - Sync with ESCOMP/main (2024-12)
  * CMEPS - Sync with ESCOMP/main (2024-12)
@FernandoAndrade-NOAA
Copy link
Collaborator

Updates were included with #2469, closing this out.

WalterKolczynski-NOAA added a commit to NOAA-EMC/global-workflow that referenced this pull request Jan 17, 2025
This PR adds the following: 
* converting from inp -> nml (@sbanihash) 
* turning on PIO for waves for restarts (@sbanihash) 
* enabling cycling for WW3 which required some updates to wave prep jobs
+ changing what restarts are being saved/etc
* changed the way CEMPS, MOM6, CICE and WW3 write restarts to be in sync
with FV3 for IAU, which required moving the ufs-weather-model forward
one hash to use the new flexible restart feature. (UFS PR
ufs-community/ufs-weather-model#2419)
* adds uglo_15km - the targeted new wave grid. 
* Update to use new esmf_threading ufs.configure files which changes the
toggle between how you use esmf threading versus traditional threading
(UFS PR ufs-community/ufs-weather-model#2538)

Notes on ufs-weather-model updates: 
| Commit date | Commit hash/ PR | Notes for g-w changes | Baseline
Changes |
| :------------- | :------------- | :------------- | :------------- |
| Dec 11, 2024 |
ufs-community/ufs-weather-model@409bc85
ufs-community/ufs-weather-model#2419 | Enables
flexible restart writes - changes included in g-w PR | none|
| Dec 16, 2024 |
ufs-community/ufs-weather-model@6ec6b45
ufs-community/ufs-weather-model#2528
ufs-community/ufs-weather-model#2469 | n/a |
HAFs test changes, no global changes |
| Dec 18, 2024
|ufs-community/ufs-weather-model@e119370
ufs-community/ufs-weather-model#2448 | Adds Gaea
C6 support (changes in other g-w PRs, not here) | none |
|Dec 23, 2024 |
ufs-community/ufs-weather-model@2950089
ufs-community/ufs-weather-model#2533
ufs-community/ufs-weather-model#2538 | changes
for ESMF vs traditional threading | none |
|Dec 30, 2024 |
ufs-community/ufs-weather-model@241dd8e
ufs-community/ufs-weather-model#2485 | n/a |
changes in conus13km, no global changes|
|Jan 3, 2025 |
ufs-community/ufs-weather-model@76471dc
ufs-community/ufs-weather-model#2530 | n/a |
changes in regional tests, no global changes |

Note this PR requires the following: 
* update to fix files to add uglo_15km 
* staging ICs for high resolution test case for uglo_15km 

Co-author: @sbanihash 

Related Issues: 
- Fixes #1457 
- Fixes #3154
- Fixes #1795 
- related to #1776 

---------

Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Saeideh Banihashemi <[email protected]>
Co-authored-by: David Huber <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants