Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/public-v1: update ccpp-physics (fix unicode errors), downgrade Intel compiler #204

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Sep 17, 2020

For a description of the problem and how it is solved, see NCAR/ccpp-physics#499. This PR only updates the submodule pointer for ccpp-physics.

Other changes:

Note that we will need to retag ufs-weather-model v1.1.0 after this PR is merged.

Testing

Regression tests will be run against existing baselines (simply copy to new date tag) on hera.intel and cheyenne.gnu; new baselines will be created for cheyenne.intel

Dependencies

NCAR/ccpp-physics#499
NOAA-EMC/fv3atm#172
#204

@climbfuji climbfuji changed the title release/public-v1: update ccpp-physics (fix unicode errors) release/public-v1: update ccpp-physics (fix unicode errors), downgrade Intel compiler Sep 18, 2020
@climbfuji climbfuji force-pushed the fix_unicode_errors_ccpp_physics branch from ce9e41e to d35721e Compare September 19, 2020 20:01
@climbfuji climbfuji marked this pull request as ready for review September 21, 2020 19:49
@climbfuji
Copy link
Collaborator Author

@junwang-noaa ready to merge.

@junwang-noaa junwang-noaa merged commit 5bea16b into ufs-community:release/public-v1 Sep 21, 2020
@climbfuji
Copy link
Collaborator Author

Thanks! Another one to retag as ufs-v1.1.0, please:

commit 5bea16b6d41d810dc2e45cba0fa3841f45ea7c7a (HEAD, noaa-emc/release/public-v1)
Author: Dom Heinzeller <[email protected]>
Date:   Mon Sep 21 14:59:48 2020 -0600

    release/public-v1: update ccpp-physics (fix unicode errors), downgrade Intel compiler (#204)

    * Update .gitmodules and submodule pointer for fv3atm
    * Revert Intel compiler back from 19.x.y to 18.m.n on Cheyenne and Gaea
    * Revert change to .gitmodules and update submodule pointer for fv3atm

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Sep 21, 2020 via email

@climbfuji
Copy link
Collaborator Author

Please see: https://github.com/ufs-community/ufs-weather-model/tree/ufs-v1.1.0

Great, thank you! I checked out a fresh version of the release/public-v1 branch, and both the fv3atm and ufs-weather-model tags show up correct.

pjpegion pushed a commit to NOAA-PSL/ufs-weather-model.p7b that referenced this pull request Jul 20, 2021
…ing with frac_grid=T (ufs-community#204)

* -- Pointing to Moorthi's modifications in ccpp/physics, which fixed the crash when running GFDL MP with frac_grid=T;
-- Not setting fice to zero in order to leave lake ice untouched;
-- Restart in the coupled model with the default physics is reproducible, if bad water temperature is only filtered at initial time;
Co-authored-with: Shrinivas Moorthi <[email protected]>
Co-authored-with: Denise Worthen <[email protected]>
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model.p7b that referenced this pull request Jul 20, 2021
…erturbations (ufs-community#239)

* Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for gsl/develop branch
* RUC ice for gsl/develop (replaces ufs-community#54 and ufs-community#56) (ufs-community#60) Implementation of RUC LSM ice model in CCPP
* Fix bug in gfsphysics/GFS_layer/GFS_typedefs.F90 from merge
* Remove lsm_ruc_sfc_sice from suite FV3_GSD_v0_unified_ugwp_suite and update submodule pointer for ccpp-physics
* Remove sfc_sice from ccpp/suites/suite_FV3_GSD_v0_unified_ugwp_suite.xml
* Update gsl/develop from develop 2020/12/08 (ufs-community#61)
* Fix for updating stochastic physics on separate time-step. (ufs-community#199)
This bug fix allows the random patterns in the stochastic physics persist the for a period of time (defined as SKEBINT,SPPTINT, etc.) before calculating new patterns.
The fix is to move the allocation of the saved variables into the init section of stochastic_physics_wrapper, and remove the deallocates in the run section.
* Bug fixes in (1) running with frac_grid=T and GFDL MP and (2) restarting with frac_grid=T (ufs-community#204)
* -- Pointing to Moorthi's modifications in ccpp/physics, which fixed the crash when running GFDL MP with frac_grid=T;
-- Not setting fice to zero in order to leave lake ice untouched;
-- Restart in the coupled model with the default physics is reproducible, if bad water temperature is only filtered at initial time;
Co-authored-with: Shrinivas Moorthi <[email protected]>
Co-authored-with: Denise Worthen <[email protected]>
* Revert change to .gitmodules and update submodule pointer for ccpp-physics
* Update submodule pointer for ccpp-physics - MYNN surface layer updates and bugfixes (ufs-community#63)
* Land stochastic perturbations (wrapper PR for ufs-community#65) (ufs-community#68)
* Move initialization of stochastic physics after the physics
initialization in CCPP.
* Add albedo variables to land perturbations with lndp_type=2 option. Change to accommodate soil perturbations with RUC LSM.
* Max/min soil moisture variables are introduced via GFS_Control_type
variables instead of through the use of namelist_soilveg*. This is a
more flexible way for different LSMs.
* Added pores and resid variables for max/min soil moisture to GFS_typedefs.f90.
* Remove tracer_sanitizer from all suites and from CCPP prebuild config
* Add namelist option to apply land surface perturbations at every time step, clean up stochastic_physics/stochastic_physics_wrapper.F90
* Stochastic land perturbations: add roughness length over land to the perturbed variables (ufs-community#70)
* Added roughness length over land to the perturbed variables.
* Bugfix in gfsphysics/GFS_layer/GFS_typedefs.F90: remove Diag%cldcov, in particular the reset call because the variable is not allocated
* Update .gitmodules and submodule pointer for GFDL_atmos_cubed_sphere for code review and testing
* Revert change to .gitmodules for ccpp-physics, update submodule pointer for ccpp-physics
* Revert change to .gitmodules and update submodule pointer for GFDL_atmos_cubed_sphere
Co-authored-by: DomHeinzeller <[email protected]>
Co-authored-by: Phil Pegion <[email protected]>
Co-authored-by: shansun6 <[email protected]>
Co-authored-by: tanyasmirnova <[email protected]>
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
This PR adds the capability for tasks to fall back to default modulefile if task-specific modulefile does not exist. In doing so, it gets rid of the old, hacky way I got post to build on Cheyenne, and replaces it with a build and run process that utilizes a new cheyenne.default modulefile.

This should allow us to condense down builds on new machines to use fewer task-specific modulefiles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants