-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CICE, update ice_in for consistency w/ G-W (was #2069) #2027
Update CICE, update ice_in for consistency w/ G-W (was #2069) #2027
Conversation
@BrianCurtis-NOAA @junwang-noaa Could one of you please review the CICE PR? Thanks. |
@FernandoAndrade-NOAA Sorry for the confusion. |
Jenkins-ci ORTs failed |
I still don't have CICE PR approvals @junwang-noaa @BrianCurtis-NOAA |
All tests are successfully done. We can start merging process. @DeniseWorthen Can you merge in the CICE pr? |
@jkbk2004 Why is the commit message not what I posted? |
@DeniseWorthen Do you mean to keep/save same commit message you posted in description to squash-merge commit log? |
That is the whole point of asking the developer to provide the commit message, isn't it? Why else would we ask for it to be provided? |
@jkbk2004 We've discussed this already. Please squash and merge using the commit message provided and reviewed by other code managers in the PR template. Please also communicate this to EPIC's CM's so they are aware of this part of the process. |
Sure! |
PR Author Checklist:
Description
Update CICE to include latest changes in Consortium/main. Updates
ice_in
for consistency w/ G-W.Commit Message
Linked Issues and Pull Requests
Associated UFSWM Issues to close
ice_in.IN
in global applications #2068Subcomponent Pull Requests
Blocking Dependencies
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
41 Tests fail to run and 41 tests fail to compare
The failed tests are any test using CICE
Tests effected by changes in this PR:
Libraries
Code Managers Log
Testing Log: