Updated the lake physics of flake #163

YihuaWu-NOAA · 2020-07-08T18:36:09Z

Related PRs:

ufs-weather-model #163
fv3atm #139
ccpp-physics #462

Modify files in ufs-weather-model-flake/FV3/gfsphysics/GFS_layer/
GFS_typedefs.F90
GFS_typedefs.meta
Note: Added two variables: lakedepth and LKM (logical)

Modify file in ufs-weather-model-flake/FV3/io/
FV3GFS_io.F90
Note: read in lake depth, and reset lakefraction and lakedepth to 0 when LKM is not one

Modify files in ufs-weather-model-flake/FV3/ccpp/physics/physics/

Added threes:
flake_driv.F90
flake_driv.meta
flake.F90*

Modified:
GFS_time_vary_pre.fv3.F90
Note: Flake need julian day

3.3 Modified:
GFS_surface_composites.F90
GFS_surface_composites.meta
Note: add lake depth, and define the logical variable lake based on lakefraction and lakedepth
Then, the logical variable lake is passed to flake drive and sfc_ocean.
When lake is true, flake will be called; when lake is false, ocean model will be called

3.4 Modified
sfc_ocean.F
sfc_ocean.meta
Note: add lake, if not lake, calculation will be conducted.

Modify files in ufs-weather-model-flake/FV3/ccpp/suites/
suite_FV3_GFS_v16beta_flake.xml

  Modify files in ufs-weather-model-flake/FV3/ccpp/config/
ccpp_prebuild_config.py

    Add file in ufs-weather-model-flake/tests/tests
			fv3_ccpp_gfs_v16beta_flake

    Modify  file in ufs-weather-model-flake/tests/fv3_conf/
			ccpp_gfs_v16_flake_run.IN

  Modify  files in  ufs-weather-model-flake/parm/
ccpp_v16beta_c96.nml.IN

Modify files in mylakedir/sorc/orog.fd
lakefrac.F90 to create lake fraction and depth and add them to oro_data_tilex.nc

Replace oro_data_tilex.nc files on hera: /scratch2/NCEPDEV/fv3-cam/Yihua.Wu/noscrub/trunk-20200611 which provide model inputs.
A new baseline was created on hera: /scratch2/NCEPDEV/fv3-cam/Yihua.Wu/noscrub/REGRESSION_TEST_INTEL

DusanJovic-NOAA · 2020-07-08T18:55:44Z

tests/detect_machine.sh

@@ -1,7 +1,7 @@
 #!/bin/bash

 # Default account "nems"
-export ACCNR=${ACCNR:-nems}
+export ACCNR=${ACCNR:-fv3-cam}


Why the default account changed from nems to fv3-cam?

DusanJovic-NOAA

remove entire tests/log_orion.intel directory

DusanJovic-NOAA · 2020-07-08T19:00:12Z

tests/rt.conf_flake

@@ -0,0 +1,4 @@
+#########################################################################################################################################################################


Move these to rt.conf and delete this file.

DusanJovic-NOAA · 2020-07-08T19:04:34Z

tests/fv3_conf/compile_slurm.IN

@@ -0,0 +1,18 @@
+#!/bin/sh


remove this file. it's a temporary file created during the regression testing

DusanJovic-NOAA · 2020-07-08T19:04:43Z

tests/fv3_conf/fv3_slurm.IN

@@ -0,0 +1,43 @@
+#!/bin/sh


remove this file. it's a temporary file created during the regression testing

YihuaWu-NOAA · 2020-07-08T20:12:54Z

Hi, Dusan, So, I delete these files/directories by another pushing? Thanks! *Yihua----------------------------------------------------Yihua Wu, Ph D*I.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703

…

On Wed, Jul 8, 2020 at 3:07 PM Dusan Jovic ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In tests/fv3_conf/fv3_slurm.IN <#163 (comment)> : > @@ -0,0 +1,43 @@ +#!/bin/sh remove this file. it's a temporary file created during the regression testing — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#163 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANJBYQAFAE4D4QSEIBV3YNLR2S7NVANCNFSM4OU25YKQ> .

DusanJovic-NOAA · 2020-07-08T20:15:23Z

Hi, Dusan, So, I delete these files/directories by another pushing? Thanks! Yihua----------------------------------------------------Yihua Wu, Ph DI.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703
…
On Wed, Jul 8, 2020 at 3:07 PM Dusan Jovic @.***> wrote: @DusanJovic-NOAA commented on this pull request. ------------------------------ In tests/fv3_conf/fv3_slurm.IN <#163 (comment)> : > @@ -0,0 +1,43 @@ +#!/bin/sh remove this file. it's a temporary file created during the regression testing — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#163 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJBYQAFAE4D4QSEIBV3YNLR2S7NVANCNFSM4OU25YKQ .

Yes.

YihuaWu-NOAA · 2020-07-08T21:54:35Z

It is done. Thanks! *Yihua----------------------------------------------------Yihua Wu, Ph D*I.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703

…

On Wed, Jul 8, 2020 at 4:15 PM Dusan Jovic ***@***.***> wrote: Hi, Dusan, So, I delete these files/directories by another pushing? Thanks! *Yihua----------------------------------------------------Yihua Wu, Ph D*I.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703 … <#m_-2097742219920196394_> On Wed, Jul 8, 2020 at 3:07 PM Dusan Jovic *@*.***> wrote: ***@***.*** <https://github.com/DusanJovic-NOAA>* commented on this pull request. ------------------------------ In tests/fv3_conf/fv3_slurm.IN <#163 (comment) <#163 (comment)>> : > @@ -0,0 +1,43 @@ +#!/bin/sh remove this file. it's a temporary file created during the regression testing — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#163 (review) <#163 (review)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJBYQAFAE4D4QSEIBV3YNLR2S7NVANCNFSM4OU25YKQ . Yes. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#163 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANJBYQBNCAT66K7LM55QPVTR2THWTANCNFSM4OU25YKQ> .

DusanJovic-NOAA · 2020-07-09T13:11:49Z

.gitmodules

-	url = https://github.com/NOAA-EMC/fv3atm
-	branch = develop
+	url = https://github.com/YihuaWu-NOAA/fv3atm
+	branch = master


FV3 submodule should point to your develop branch, not master. All your changes in your fv3atm fork are in develop branch.

YihuaWu-NOAA · 2020-07-09T15:00:11Z

Hi, Dusan, Thank you very much! *Yihua----------------------------------------------------Yihua Wu, Ph D*I.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703

…

On Thu, Jul 9, 2020 at 9:12 AM Dusan Jovic ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .gitmodules <#163 (comment)> : > @@ -1,7 +1,7 @@ [submodule "FV3"] path = FV3 - url = https://github.com/NOAA-EMC/fv3atm - branch = develop + url = https://github.com/YihuaWu-NOAA/fv3atm + branch = master FV3 submodule should point to your develop branch, not master. All your changes in your fv3atm fork are in develop branch. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#163 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANJBYQGTYINU2OSHBAE2ROTR2W62JANCNFSM4OU25YKQ> .

junwang-noaa · 2020-07-14T19:12:27Z

Please see the new PR #164.

YihuaWu-NOAA · 2020-07-14T19:31:10Z

Hi, Jun, Thanks. I think you can also close #139. *Yihua----------------------------------------------------Yihua Wu, Ph D*I.M. Systems Group NOAA/NWS/NCEP/EMC 5830 University Research Court, Room: 2031 College Park, Maryland 20740, USA Phone: (301)-683-3691 Fax: (301)-683-3703

…

On Tue, Jul 14, 2020 at 3:12 PM Jun Wang ***@***.***> wrote: Please see the new PR #164 <#164>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#163 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANJBYQBGNZCQOSQIU4QJTELR3SU2XANCNFSM4OU25YKQ> .

Eliminate duplication of module load for EMC_post

Updated .gitmodules and added some files related flake

51df428

DusanJovic-NOAA reviewed Jul 8, 2020

View reviewed changes

YihuaWu-NOAA mentioned this pull request Jul 8, 2020

Added flake physics NOAA-EMC/fv3atm#139

Closed

Removed some unwanted files, such as rt.conf_flake, compile_slurm.IN

42419c6

DusanJovic-NOAA reviewed Jul 9, 2020

View reviewed changes

Updated .gitmodules and FV3

144d268

Updated FV3 submodule

49c3f81

junwang-noaa closed this Jul 14, 2020

epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023

Merge pull request #163 from JulieSchramm/cheyenne_build

b791f27

Eliminate duplication of module load for EMC_post

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated the lake physics of flake #163

Updated the lake physics of flake #163

YihuaWu-NOAA commented Jul 8, 2020 •

edited by junwang-noaa

Loading

DusanJovic-NOAA Jul 8, 2020

DusanJovic-NOAA left a comment

DusanJovic-NOAA Jul 8, 2020

DusanJovic-NOAA Jul 8, 2020

DusanJovic-NOAA Jul 8, 2020

YihuaWu-NOAA commented Jul 8, 2020 via email

DusanJovic-NOAA commented Jul 8, 2020

YihuaWu-NOAA commented Jul 8, 2020 via email

DusanJovic-NOAA Jul 9, 2020

YihuaWu-NOAA commented Jul 9, 2020 via email

junwang-noaa commented Jul 14, 2020

YihuaWu-NOAA commented Jul 14, 2020 via email

		@@ -0,0 +1,4 @@
		#########################################################################################################################################################################

Updated the lake physics of flake #163

Updated the lake physics of flake #163

Conversation

YihuaWu-NOAA commented Jul 8, 2020 • edited by junwang-noaa Loading

DusanJovic-NOAA Jul 8, 2020

Choose a reason for hiding this comment

DusanJovic-NOAA left a comment

Choose a reason for hiding this comment

DusanJovic-NOAA Jul 8, 2020

Choose a reason for hiding this comment

DusanJovic-NOAA Jul 8, 2020

Choose a reason for hiding this comment

DusanJovic-NOAA Jul 8, 2020

Choose a reason for hiding this comment

YihuaWu-NOAA commented Jul 8, 2020 via email

DusanJovic-NOAA commented Jul 8, 2020

YihuaWu-NOAA commented Jul 8, 2020 via email

DusanJovic-NOAA Jul 9, 2020

Choose a reason for hiding this comment

YihuaWu-NOAA commented Jul 9, 2020 via email

junwang-noaa commented Jul 14, 2020

YihuaWu-NOAA commented Jul 14, 2020 via email

YihuaWu-NOAA commented Jul 8, 2020 •

edited by junwang-noaa

Loading