Develop drag suite intent mods -- Changed UGWP diagnostic variable declaration intents from 'out' to 'inout' #1612

mdtoyNOAA · 2023-02-14T01:03:54Z

Description

This pull request fixes Issue #37 of the ufs-community/ccpp-physics repository. The UGWP diagnostic variables (i.e., dusfc_ms, dvsfc_ms, tdaux2d_ms, datauy2d_ms, etc.) are declared with "intent(out)" and initialized in module unified_ugwp.F90, then they are passed to subroutine "drag_suite_run" (in drag_suite.F90). In this subroutine, the UGWP diagnostic variables should have been declared with "intent(inout)" instead of "intent(out)". This PR fixes this.
This PR does not change any results.

Top of commit queue on: TBD

Input data additions/changes

No changes are expected to input data.
There will be new input data.
Input data will be updated.

Anticipated changes to regression tests:

No changes are expected to any regression test.
Changes are expected to the following tests:

Subcomponents involved:

Combined with PR's (If Applicable):

Commit Queue Checklist:

Link PR's from all sub-components involved
Confirm reviews completed in sub-component PR's
Add all appropriate labels to this PR.
Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Dependent pull requests:

Related issue:

fixes Possible correction to declaration intent for diagnostic variables in drag_suite.F90 ccpp-physics#37

Testing Day Checklist:

This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

RDHPCS
- Intel
  - Hera
  - Orion
  - Jet
  - Gaea
  - Cheyenne
- GNU
  - Hera
  - Cheyenne
WCOSS2
- Dogwood/Cactus
- Acorn
CI
- Completed
opnReqTest
- N/A
- Log attached to comment

…nout'

jkbk2004 · 2023-02-16T19:41:15Z

@mdtoyNOAA We are currently working on #1529. As discussed before, this pr can be combined to #1597. I will check again after we merge in #1529. We can coordinate with @binli2337 then.

mdtoyNOAA · 2023-02-16T20:24:08Z

@mdtoyNOAA We are currently working on #1529. As discussed before, this pr can be combined to #1597. I will check again after we merge in #1529. We can coordinate with @binli2337 then.

@jkbk2004 Sounds good.

DeniseWorthen · 2023-02-17T15:00:44Z

It does not appear that the GNU suite was run. Also FV3 is out of date.

…r-model into develop_drag_suite_intent_mods

mdtoyNOAA · 2023-02-17T15:45:37Z

@jkbk2004 I've merged the latest changes to "ufs-weather-model" and "FV3ATM" in my fork. Would you like me to retest Intel and test GNU?

jkbk2004 · 2023-02-17T15:58:17Z

@mdtoyNOAA you are bringing in the change from gsl fork branches. It's a bit tricky. Easiest solution is to go with community develop and emc fv3 develop. Since this pr is small change, I think it's doable to re-create pr. What do you think? we are still working on #1529. There is enough time.

mdtoyNOAA · 2023-02-17T16:29:12Z

@jkbk2004 Actually, I am not bringing in changes from the GSL fork branches. Although I did originally fork my ufs-weather-model repo from NOAA-GSL, the branches related to this PR are strictly based on the ufs-community repos. To double check this, I just cloned my ufs-weather-model repo into a fresh directory and "git diffed" each component, i.e., ufs-weather-model, fv3atm, and ccpp/physics, and they are all synched (except for my "inout" mods) to the ufs-community repos/branches. So, I shouldn't need to redo the PR. Please let me know if you agree.

jkbk2004 · 2023-02-17T16:35:56Z

@jkbk2004 Actually, I am not bringing in changes from the GSL fork branches. Although I did originally fork my ufs-weather-model repo from NOAA-GSL, the branches related to this PR are strictly based on the ufs-community repos. To double check this, I just cloned my ufs-weather-model repo into a fresh directory and "git diffed" each component, i.e., ufs-weather-model, fv3atm, and ccpp/physics, and they are all synched (except for my "inout" mods) to the ufs-community repos/branches. So, I shouldn't need to redo the PR. Please let me know if you agree.

cool! sounds at least synching branch is working. Once we don't see conflictions to resolve, we are fine.

jkbk2004 · 2023-02-17T16:44:09Z

@mdtoyNOAA hera is very slow from yesterday. Do you have access to Cheyenne? I can help to make a quick test on cheyenne with gnu.

mdtoyNOAA · 2023-02-17T16:45:22Z

@mdtoyNOAA hera is very slow from yesterday. Do you have access to Cheyenne? I can help to make a quick test on cheyenne with gnu.

@jkbk2004 No, I don't have access to Cheyenne.

jkbk2004 · 2023-02-17T18:53:54Z

@mdtoyNOAA let me give a quick test on cheyenne. Anyway, we like to start working on this pr today with combining to #1597

jkbk2004 · 2023-02-17T20:48:27Z

RegressionTests_cheyenne.gnu.log

cheyenn.gnu reproduces

jkbk2004 · 2023-02-17T22:35:11Z

@mdtoyNOAA Ok! #1529 was merged in. So, we can start working to combine this pr to #1597. Can you sync up ccpp and fv3 one more time? I will ask @binli2337 to point to your fv3 branch in his pr.

…r-model into develop_drag_suite_intent_mods

mdtoyNOAA · 2023-02-17T22:44:08Z

@jkbk2004 I am working on it right now. Can you confirm that there have been changes to the submodules 'WW3' and 'upp'?

jkbk2004 · 2023-02-17T22:50:33Z

Yes, upp was update: https://github.com/NOAA-EMC/UPP/tree/b37f8ab7b0f298346d79a37e0c5d4a64037fd4d4
ww3 no update and the hash is still in last month: https://github.com/NOAA-EMC/WW3/tree/b93b9f00118f6fb316fd2289dff10b1455357f3f

mdtoyNOAA · 2023-02-17T23:07:13Z

Sorry, I meant ’NOAHMP-interface/noahmp’.

…

On Feb 17, 2023, at 3:50 PM, JONG KIM ***@***.***> wrote: Yes, upp was update: https://github.com/NOAA-EMC/UPP/tree/b37f8ab7b0f298346d79a37e0c5d4a64037fd4d4 <https://github.com/NOAA-EMC/UPP/tree/b37f8ab7b0f298346d79a37e0c5d4a64037fd4d4> ww3 no update and the hash is still in last month: https://github.com/NOAA-EMC/WW3/tree/b93b9f00118f6fb316fd2289dff10b1455357f3f <https://github.com/NOAA-EMC/WW3/tree/b93b9f00118f6fb316fd2289dff10b1455357f3f> — Reply to this email directly, view it on GitHub <#1612 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARRVLIBNZOKZZE6R5UCI3ZLWX76EHANCNFSM6AAAAAAU26DLMU>. You are receiving this because you were mentioned.

jkbk2004 · 2023-02-17T23:09:19Z

Oh! you are correct. noah-mp was update.

mdtoyNOAA · 2023-02-17T23:13:35Z

@jkbk2004 I updated my UPP branch and it looks like the latest hash is '84cp0b8f', not 'b37f8ab7'. Should I revert back to this older hash?

Gitlog below:

commit 84cb0b8ff4d72506edddff6204d00f39bc3f035a (HEAD, origin/develop, origin/HEAD)
Author: YaliMao-NOAA [email protected]
Date: Wed Feb 15 21:27:43 2023 -0500

update gtg code revision (#632)

Co-authored-by: yali mao <[email protected]>

commit ad56e5ca699728df7b300e3624807a6d21dcf186
Author: Gillian Petro [email protected]
Date: Tue Feb 14 10:21:31 2023 -0500

Update documentation for variables in CALGUST.f and CALHEL.f (#630)

* Correct DEPTH param in CALHEL

* add def for LPBL and ZPBL

* reorder variables in header

---------

Co-authored-by: gspetro <[email protected]>

commit 8c7ca6f36a0347b457e5de89b3b40c79a87ca353
Author: EricJames-NOAA [email protected]
Date: Mon Feb 13 18:09:04 2023 -0700

Small changes to exp2 ceiling and SLP output (#629)

* Correcting name of MAPS SLP variable in post_avblflds.xml, and removing from RRFS postxconfig file, and a slight change to exp2 ceiling diagnostic.

* Small change to MDLFLD to make sure REFD at -10C still gets output after getting rid of MSLMA output.

* Adding change logs.

* Adding NCEP local use for MSLMA

commit b37f8ab7b0f298346d79a37e0c5d4a64037fd4d4
Author: WenMeng-NOAA [email protected]
Date: Mon Feb 13 09:43:43 2023 -0500

jkbk2004 · 2023-02-17T23:16:18Z

upp b37f8ab7 is the one we are using.

mdtoyNOAA · 2023-02-17T23:23:51Z

@jkbk2004 Okay, I think I have it synched and pushed properly. Let me know if it looks okay. Thanks.

jkbk2004 · 2023-02-18T00:09:04Z

@mdtoyNOAA one thing to confirm. this pr has not much to do with noahmp, right? Only code change comes from ccpp. So, @binli2337 can simply poin to your fv3 branch to combine the PRs, right?

mdtoyNOAA · 2023-02-18T04:28:46Z

That’s correct. This PR has nothing to do with noahmp.

…

On Feb 17, 2023, at 5:09 PM, JONG KIM ***@***.***> wrote: @mdtoyNOAA <https://github.com/mdtoyNOAA> one thing to confirm. this pr has not much to do with noahmp, right? Only code change comes from ccpp. So, @binli2337 <https://github.com/binli2337> can simply poin to your fv3 branch to combine the PRs, right? — Reply to this email directly, view it on GitHub <#1612 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARRVLIAT5TNPSKHQOBYKYP3WYAHKZANCNFSM6AAAAAAU26DLMU>. You are receiving this because you were mentioned.

mdtoyNOAA added 3 commits February 13, 2023 18:51

Changed UGWP diagnostic variable declaration intents from 'out' to 'i…

c7fe97a

…nout'

Performed regression testing

6419551

Updated UGWP diagnostic variable declaration intents in drag_suite.meta

016dec1

jkbk2004 mentioned this pull request Feb 15, 2023

Update CDEPS component; update documentation FAQ about setting resources and turning off output; update FAQ documentation (was 1608); update drag suite intent mods (was 1612) #1597

Merged

37 tasks

Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…

fcb11d4

…r-model into develop_drag_suite_intent_mods

DeniseWorthen added the No Baseline Change No Baseline Change label Feb 17, 2023

Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…

1b1eeac

…r-model into develop_drag_suite_intent_mods

Updated NOAHMP submodule

b6e6a73

jkbk2004 closed this in #1597 Feb 22, 2023

This was referenced Mar 2, 2023

UFS-dev PR40 #1637

Closed

UFS-dev PR#40 NCAR/ufs-weather-model#88

Merged

mdtoyNOAA deleted the develop_drag_suite_intent_mods branch March 9, 2023 20:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop drag suite intent mods -- Changed UGWP diagnostic variable declaration intents from 'out' to 'inout' #1612

Develop drag suite intent mods -- Changed UGWP diagnostic variable declaration intents from 'out' to 'inout' #1612

mdtoyNOAA commented Feb 14, 2023 •

edited by DeniseWorthen

Loading

jkbk2004 commented Feb 16, 2023

mdtoyNOAA commented Feb 16, 2023

DeniseWorthen commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023 via email

jkbk2004 commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023

jkbk2004 commented Feb 18, 2023

mdtoyNOAA commented Feb 18, 2023 via email

Develop drag suite intent mods -- Changed UGWP diagnostic variable declaration intents from 'out' to 'inout' #1612

Develop drag suite intent mods -- Changed UGWP diagnostic variable declaration intents from 'out' to 'inout' #1612

Conversation

mdtoyNOAA commented Feb 14, 2023 • edited by DeniseWorthen Loading

Description

Top of commit queue on: TBD

Input data additions/changes

Anticipated changes to regression tests:

Subcomponents involved:

Combined with PR's (If Applicable):

Commit Queue Checklist:

Linked PR's and Issues:

Testing Day Checklist:

Testing Log (for CM's):

jkbk2004 commented Feb 16, 2023

mdtoyNOAA commented Feb 16, 2023

DeniseWorthen commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023 via email

jkbk2004 commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023

jkbk2004 commented Feb 17, 2023

mdtoyNOAA commented Feb 17, 2023

jkbk2004 commented Feb 18, 2023

mdtoyNOAA commented Feb 18, 2023 via email

mdtoyNOAA commented Feb 14, 2023 •

edited by DeniseWorthen

Loading