NCAR-main PR#956

[dustinswales]

Description

This PR contains new interstitial variables in GFS_typedefs to accommodate changes in the underlying physics. These changes are mostly related to the removal of a radiation configuration(data) module, physparam.f. Runtime information is set in GFS_typedefs and provided through the ccpp infrastructure, instead of referencing physparam.f throughout the physics.

Issue(s) addressed

Detailed in NCAR #956

Testing

Tested on Cheyenne and Hera with Intel.
Updates need for the RRTMGP RTs (see conversation in NCAR/ccpp-physics#956)

Top of commit queue on: TBD

Input data additions/changes

• No changes are expected to input data.
• There will be new input data.
• Input data will be updated.

Anticipated changes to regression tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests: control_p8_rrtmgp

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Combined with PR's (If Applicable):

Commit Queue Checklist:

• Link PR's from all sub-components involved
• Confirm reviews completed in sub-component PR's
• Add all appropriate labels to this PR.
• Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
• Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

• depends on NCAR-main PR#956 NOAA-EMC/fv3atm#623
• depends on NCAR-main PR#956 ccpp-physics#38

Testing Day Checklist:

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

• RDHPCS
  • Intel
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • GNU
    • Hera
    • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[zach1221]

Hi, @dustinswales. We are going to merge PR #1599 soon, then we'll begin working this one. Would you be able to resolve conflicts?

[dustinswales]

@zach1221 Should be all up-to-date now.

[zach1221]

@dustinswales thank you. Please attach your test logs as well, if you have them.

[dustinswales]

@zach1221 Sorry, I just wiped my logs when I synced. (I will make note to save for future PRs)

[jkbk2004]

@dustinswales hycom is pointing to https://github.com/dustinswales/ufs-weather-model/tree/ncar-main-PR956/HYCOM-interface. Can you fix? this pr has nothing to do with hycom.

[zach1221]

Please see Jenkins-ci logs attached. ORT have passed.
ufs-weather-model » ort-docker-pipeline » PR-1604 #1 Console [Jenkins].pdf

[dustinswales]

@dustinswales hycom is pointing to https://github.com/dustinswales/ufs-weather-model/tree/ncar-main-PR956/HYCOM-interface. Can you fix? this pr has nothing to do with hycom.

@jkbk2004 Sorry, I don't see any issues w/ hycom?

[jkbk2004]

@dustinswales hycom is pointing to https://github.com/dustinswales/ufs-weather-model/tree/ncar-main-PR956/HYCOM-interface. Can you fix? this pr has nothing to do with hycom.

@jkbk2004 Sorry, I don't see any issues w/ hycom?

It should point to develop/HYCOM-interface. And I see 6 commit ahead in your ncar-main-PR956 branch
. I am wondering how test passes if some code change in hycom.

[dustinswales]

@dustinswales hycom is pointing to https://github.com/dustinswales/ufs-weather-model/tree/ncar-main-PR956/HYCOM-interface. Can you fix? this pr has nothing to do with hycom.

@jkbk2004 Sorry, I don't see any issues w/ hycom?

It should point to develop/HYCOM-interface. And I see 6 commit ahead in your ncar-main-PR956 branch . I am wondering how test passes if some code change in hycom.

It's pointing to the correct. place. No? (The 6 commits are only in the FV3)

[jkbk2004]

@dustinswales hycom is pointing to https://github.com/dustinswales/ufs-weather-model/tree/ncar-main-PR956/HYCOM-interface. Can you fix? this pr has nothing to do with hycom.

@jkbk2004 Sorry, I don't see any issues w/ hycom?

It should point to develop/HYCOM-interface. And I see 6 commit ahead in your ncar-main-PR956 branch . I am wondering how test passes if some code change in hycom.

It's pointing to the correct. place. No? (The 6 commits are only in the FV3)

let me try to build test for a hafs case.

[DeniseWorthen]

I also don't understand the issue. Dustin's PR is using HYCOM hash 2443753. That is the current hash in UWM.

[jkbk2004]

I also don't understand the issue. Dustin's PR is using HYCOM hash 2443753. That is the current hash in UWM.

I could be wrong. let me test manually on cheyenne to confirm.

[jkbk2004]

RegressionTests_cheyenne.intel.log
RegressionTests_cheyenne.gnu.log
Ignore my previous comment! Confirm all fine. We need to create new baseline only for control_p8_rrtmgp

[jkbk2004]

@zach1221 I will extend my test on cheyenne to create and copy control_p8_rrtmgp to new BL_DATE.

[jkbk2004]

Automated RT Failure Notification
Machine: gaea
Compiler: intel
Job: RT
[RT] Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/1234188003/20230228173019/ufs-weather-model
[RT] Error: Test cpld_debug_p8 015 failed in run_test failed
[RT] Error: Test rap_progcld_thompson_debug 092 failed in run_test failed
Please make changes and add the following label back: gaea-intel-RT

[jkbk2004]

Automated RT Failure Notification
Machine: orion
Compiler: intel
Job: RT
[RT] Repo location: /work/noaa/epic-ps/jongkim/autort/pr/1234188003/20230228110118/ufs-weather-model
[RT] Error: Test compile_001 failed in run_compile failed
[RT] Error: Test compile_002 failed in run_compile failed
[RT] Error: Test compile_003 failed in run_compile failed
[RT] Error: Test compile_004 failed in run_compile failed
[RT] Error: Test compile_005 failed in run_compile failed
[RT] Error: Test compile_006 failed in run_compile failed
[RT] Error: Test compile_007 failed in run_compile failed
[RT] Error: Test compile_008 failed in run_compile failed
[RT] Error: Test compile_009 failed in run_compile failed
[RT] Error: Test compile_010 failed in run_compile failed
[RT] Error: Test compile_011 failed in run_compile failed
[RT] Error: Test compile_012 failed in run_compile failed
[RT] Error: Test compile_013 failed in run_compile failed
[RT] Error: Test compile_014 failed in run_compile failed
[RT] Error: Test compile_015 failed in run_compile failed
[RT] Error: Test compile_016 failed in run_compile failed
[RT] Error: Test compile_017 failed in run_compile failed
[RT] Error: Test compile_018 failed in run_compile failed
[RT] Error: Test compile_019 failed in run_compile failed
[RT] Error: Test compile_020 failed in run_compile failed
[RT] Error: Test compile_021 failed in run_compile failed
[RT] Error: Test compile_025 failed in run_compile failed
[RT] Error: Test compile_026 failed in run_compile failed
[RT] Error: Test compile_027 failed in run_compile failed
[RT] Error: Test compile_028 failed in run_compile failed
[RT] Error: Test compile_029 failed in run_compile failed
Please make changes and add the following label back: orion-intel-RT

[zach1221]

Time out issue caused two tests to fail on Gaea, those were run successfully via manual process.
Orion failures also appear system related. We'll attempt to complete those manually as well.

[jkbk2004]

Sounds like orion system issue with git module: need version 28. Some people started complaining about it.

[BrianCurtis-NOAA]

You can skip Cactus for this. I've confirmed the permissions were incorrect on 12 tests in the develop-20230227 directory and fixed that issue. This was the cause of the 12 tests that failed the RT. Let's not delay this any further.

[jkbk2004]

Sure, we will start merging process.

[jkbk2004]

@dustinswales can you update fv3 hash NOAA-EMC/fv3atm@c932926 ?