-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CMake build system for AQM #1445
Update CMake build system for AQM #1445
Conversation
Ran regional_atmaq on hera.intel and no changes to baselines.
|
@BrianCurtis-NOAA please bring these up to date with respective authoritative repositories
|
…r-model into aqm_cmake_updates
on-behalf-of @ufs-community <[email protected]>
on-behalf-of @ufs-community <[email protected]>
on-behalf-of @ufs-community <[email protected]>
on-behalf-of @ufs-community <[email protected]>
@BrianCurtis-NOAA it turns out git version issue on jenkins-ci side. I am running on a sandbox jenkins pipeline. it is running ok but slow as the sandbox was set up as sequential. We are ok to move on to merge the PR. |
NOAA-EMC/AQM/pull/15 is merged. Ready for merge here. |
@jkbk2004 Does Jenkins-CI run OK? Can users see the run log file? |
@BrianCurtis-NOAA Zach is monitoring the Jenkins-ci run with fix now. Let's merge in jenkins-ci log first thing tomorrow. I like to force to have jenkins-ci log. |
Run log below from Jenkins. Please let me know if anything else is needed. |
@zach1221 We need to resolve the public accessibility issue of full jenkins-ci log outputs in the PR. Please, continue to follow up with Jenkins team. |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Description
AQM Currently fails debug builds and has an issue with building serially and module_mod. The changes in this PR address the below issues in AQM
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
NOAA-EMC/AQM#10
NOAA-EMC/AQM#14
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs