-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cmeps capable atm-wav test #1407
add cmeps capable atm-wav test #1407
Conversation
* test now updates to v17+P8. need to test
* orginal version is atmwm (m=multi); atmw = cmeps/mesh cap
* control_atmwav is b4b, atmwav_control_noaero_p8 (cmeps) runs to completions but has missing baseline * input_nml for control_p8 and atmwave p8 test are different only in cplwav and cplwav2atm logicals
This PR depends on the prior merge of PR #1366. CI failure is expected until that PR is committed. |
@JessicaMeixner-NOAA can I make sure if we need more time on this pr ? |
I'd like to see some changes in this PR, but I do not know if those will be persued, so I think the question would be better suited for @DeniseWorthen |
@jkbk2004 @JessicaMeixner-NOAA I don't need this PR for current work on the unstructured mesh, which is why I created the additional test. At this point, I believe I can put this PR on hold while I do the early development work for the unstructured mesh. I will move this PR to draft stage. |
Sure! I agree it's better to put on hold. |
@DeniseWorthen sounds like tuning configuration is needed for hafs_regional_atm_ocn_wav and atmwav_control_noaero_p8. |
@jkbk2004 I believe all should be good now. |
Skip Acorn: #1705 |
Sure! all tests are done. @JessicaMeixner-NOAA @MatthewMasarik-NOAA Please, go ahead for final reviews and approvals |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
ATMWM
and switches the remaining non-cmeps wave coupled test to that app. The existingATMW
app will be built with the CMEPS mediator and use the wave mesh cap.Issue(s) addressed
Testing
Baselines were run at 74129c3. All Hera.gnu tests passed. For Hera.intel, only tests containing waves were run.
All baselines passed except for:
atmwav_control_noaero_p8
: ran to completion but failed due to missing baseline. Theinput.nml
was comparedto the
input.nml
from the thecontrol_p8
run and they differed only in the settings for wav-coupling (cplwav
andcplwav2atm
hafs_regional_atm_wav
,hafs_regional_atm_ocn_wav
andhafs_regional_storm_following_1nest_atm_ocn_wav
: gridded output and points files are now created as time-stamped files and have a missing comparison files. For example,20190829.060000.out_grd.ww3
instead ofout_grd.ww3
. Manually comparing the baseline files against the timestamped files usingcmp
shows they are different. All other files for these tests reproduce.The timestamped files are created by setting
date%point%outffile = '1'
anddate%field%outffile = '1'
in theww3_shel.nml
. To verify that the difference in the files was not in the actual data, a test run was carried out using thehafs_regional_atm_wav
test. Removing theoutfile
setting produced non-timestamped files which reproduced the files in the baseline.The above results were confirmed to still be valid at 5c05dea. All tests are B4B on hera.gnu. On hera.intel
RegressionTests_cheyenne.gnu.log
RegressionTests_cheyenne.intel.log
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies