Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc NRL bugfixes #1384

Merged
merged 14 commits into from
Sep 12, 2022
Merged

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Aug 24, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

See the descriptions in NCAR/ccpp-physics#954 and NOAA-EMC/fv3atm#576 for details.

Issue(s) addressed

NCAR/ccpp-physics#955

Testing

See NOAA-EMC/fv3atm#576 for testing details.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

NOAA-EMC/fv3atm#576
NCAR/ccpp-physics#954

@grantfirl grantfirl changed the title update .gitmodules and FV3 submodule pointer for RTs Misc NRL bugfixes Aug 26, 2022
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 9, 2022

@grantfirl sorry for delaying. we will merge in #1399 around lunch time today. and then we can start working on this PR.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 9, 2022

@grantfirl can you sync up branch? and then I will add new BL_DATE. we can start working on this pr.

@grantfirl
Copy link
Collaborator Author

@grantfirl can you sync up branch? and then I will add new BL_DATE. we can start working on this pr.

OK @jkbk2004 This PR and all submodule PRs have been updated/synced with the latest develop/main branches after the AQM merge.

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: orion
Compiler: intel
Job: BL
[BL] Repo location: /work/noaa/nems/emc.nemspara/autort/pr/1035943918/20220909193022/ufs-weather-model
[BL] Error: Test compile_017 failed in run_compile failed
[BL] Error: Test compile_018 failed in run_compile failed
Please make changes and add the following label back: orion-intel-BL

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: gaea
Compiler: intel
Job: BL
[BL] Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/1035943918/20220910003007/ufs-weather-model
[BL] Error: Test hafs_global_storm_following_1nest_atm 092 failed in run_test failed
Please make changes and add the following label back: gaea-intel-BL

@BrianCurtis-NOAA
Copy link
Collaborator

@jkbk2004 Could you start adding comments with reasons for failure seen on machines (orion & gaea in this case). It would be good to know and keep track of.

@jkbk2004
Copy link
Collaborator

gaea failure was "Slurm unknown status": it ran ok with re-submission. On orion, it seems there is a git issue: HYCOM: manually ran. Following up with help desk.

@jkbk2004
Copy link
Collaborator

@grantfirl all tests are done. we can start merging in dependencies: ccpp first.

@grantfirl
Copy link
Collaborator Author

@jkbk2004 ccpp-physics has been merged and the fv3atm PR branch has been updated.

@jkbk2004
Copy link
Collaborator

@grantfirl we can merge in after updating fv3 pointer and reverting branch in gitmodules.

@grantfirl
Copy link
Collaborator Author

@jkbk2004 OK, should be good to go now.

@jkbk2004 jkbk2004 merged commit b10ddb3 into ufs-community:develop Sep 12, 2022
@BrianCurtis-NOAA
Copy link
Collaborator

Just noting that tests also passed on Acorn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants