Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore checksum option and performance with (1,1) io layout #1275

Closed
wants to merge 5 commits into from

Conversation

junwang-noaa
Copy link
Collaborator

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

The PR includes code changes related to dycore NOAA-GFDL/GFDL_atmos_cubed_sphere#197. In PR#197, an option is added to allow one to override restart data integrity checks enforced for FMS-based io, also the PR has enhancements to improve new FMS-based io when using an io_layout of (1,1)

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

@jkbk2004
Copy link
Collaborator

@junwang-noaa I think we can start working the PR?

jkbk2004 pushed a commit that referenced this pull request Jun 29, 2022
…ecksum option and performance with (1,1) io layout in FV3 (#1294)

* Remove WCOSS Cray and Dell support from regression tests

* Remove two unnecessary COMPILE steps for DEBUG ATM tests

* Update FV3 submodule (combining this PR with #1275)
@DeniseWorthen
Copy link
Collaborator

@junwang-noaa This got merged w/ Dusan's wcoss1 removal PR, right?

@jkbk2004
Copy link
Collaborator

@junwang-noaa This got merged w/ Dusan's wcoss1 removal PR, right?

Yes

@DeniseWorthen
Copy link
Collaborator

Code was committed with PR #1294

@junwang-noaa junwang-noaa deleted the checksum_io branch February 8, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore checksum option and performance with (1,1) io layout
5 participants