Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync ww3/dev/ufs-weather-model #1228

Merged
merged 28 commits into from
May 29, 2022

Conversation

aliabdolali
Copy link
Collaborator

@aliabdolali aliabdolali commented May 20, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Sync WW3/dev/ufs-weather-model to the top of WW3/develop
No changes in the results and no need to recreate new mod_def files.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI 8de079e

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@aliabdolali
Copy link
Collaborator Author

The regtests are submitted on hera, will post updates on changes soon

@aliabdolali
Copy link
Collaborator Author

@junwang-noaa @DeniseWorthen
There are no changes in results, so we can combine it with another PR.

@junwang-noaa
Copy link
Collaborator

@aliabdolali Can we work on the PR today?

@junwang-noaa junwang-noaa added the No Baseline Change No Baseline Change label May 23, 2022
@github-actions
Copy link

@aliabdolali please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date

@aliabdolali
Copy link
Collaborator Author

@aliabdolali Can we work on the PR today?

@junwang-noaa I think so, my test on Hera showed no changes in the outputs, so we are good to merge.

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: RT
[RT] Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/942708115/20220527131512/ufs-weather-model
Please make changes and add the following label back: hera-intel-RT

@junwang-noaa
Copy link
Collaborator

The last test is not finished yet on hera.intel, while the autoRT is done.

@DeniseWorthen
Copy link
Collaborator

It looks like the c384 restart job finally finished, but it never really advanced from what I can tell. It just timed out.

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: RT
[RT] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/942708115/20220527131518/ufs-weather-model
[RT] Error: Test hafs_regional_atm_thompson_gfdlsf 088 failed in run_test failed
Please make changes and add the following label back: jet-intel-RT

@junwang-noaa
Copy link
Collaborator

I am rerunning the RT on hera

@DeniseWorthen
Copy link
Collaborator

This is the same test that we had problems w/ on Bin Liu's PR.

@junwang-noaa
Copy link
Collaborator

The hafs_regional_atm_thompson_gfdlsf did not start to run on jet. Will rerun it.

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: gaea
Compiler: intel
Job: RT
[RT] Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/942708115/20220527201507/ufs-weather-model
[RT] Error: Test cpld_control_c384_p8 010 failed in run_test failed
Please make changes and add the following label back: gaea-intel-RT

@junwang-noaa junwang-noaa merged commit ec17713 into ufs-community:develop May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfaults when running cpld aerosol model with GNU 9 and 10
5 participants