-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync ww3/dev/ufs-weather-model #1228
Conversation
The regtests are submitted on hera, will post updates on changes soon |
@junwang-noaa @DeniseWorthen |
@aliabdolali Can we work on the PR today? |
@aliabdolali please bring these up to date with respective authoritative repositories
|
@junwang-noaa I think so, my test on Hera showed no changes in the outputs, so we are good to merge. |
on-behalf-of @ufs-community <[email protected]>
Automated RT Failure Notification |
The last test is not finished yet on hera.intel, while the autoRT is done. |
It looks like the c384 restart job finally finished, but it never really advanced from what I can tell. It just timed out. |
Automated RT Failure Notification |
I am rerunning the RT on hera |
This is the same test that we had problems w/ on Bin Liu's PR. |
The hafs_regional_atm_thompson_gfdlsf did not start to run on jet. Will rerun it. |
of hafs_global_storm_following_1nest_atm as it failed the first time
which failed on the first attempt
Automated RT Failure Notification |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Sync WW3/dev/ufs-weather-model to the top of WW3/develop
No changes in the results and no need to recreate new mod_def files.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs