add mynn surface scheme as opt_sfc=4 in NoahMP #1224
Conversation
|
@HelinWei-NOAA I think we can start working on this PR. Can you sync up your branches to develop/main: ccpp and fv3atm? |
revert back to the default setting
|
@HelinWei-NOAA please bring these up to date with respective authoritative repositories
|
|
Which submodules are not up to date? Thanks.
|
|
@SamuelTrahanNOAA Please check the changes in tests/parm/rrfs_conus13km_hrrr.nml.IN |
|
Something is wrong with this PR. Description says it depends on fv3atm PR 537, but .gitmodules does not point to a fork with that PR, it still points to NOAA-EMC |
|
Could @joeolson42 please review these changes? |
@SamuelTrahanNOAA added @joeolson42 to the repo. |
|
At this moment I have reverted all opt_sfc changes. In the future we will redesign some RTs using opt_sfc=4. |
You have not reverted the changes to the conus13km namelist. |
|
@HelinWei-NOAA can you address the reviewers' comments above? |
|
Automated RT Failure Notification |
|
Automated RT Failure Notification |
|
@HelinWei-NOAA Please, resolved the conversations. @DeniseWorthen @DusanJovic-NOAA @SamuelTrahanNOAA The PR is ready for final comments and approval. All RTs passed. |
|
@jkbk2004 Github will not let me resolve the conversations. Perhaps only the author and people with write access can do that? I have re-reviewed and given my approval. |
|
I've resolved what I can see of the conversations and approved. |
|
@jkbk2004 I didn't see any unresolved conversions. Just waiting for Dusan's approval. |
|
FV3 submodule still points to fork's URL/branch. |
|
We need to merge ccpp-physics branch first, then FV3.
|
@HelinWei-NOAA can you work with @SamuelTrahanNOAA to merge in ccpp pr first? |
|
@jkbk2004 ccpp-physics is merged |
|
@SamuelTrahanNOAA Thanks. Now I need to update my FV3 branch and then someone can merge my FV3 PR. |
|
I cannot merge to fv3atm, but I'm sure there's someone else monitoring this who can merge. |
|
@HelinWei-NOAA can you make last update of fv3atm pointer and revert submodule pointer? |
Done. |
|
@DusanJovic-NOAA all ready to merge. Can you approve? |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
issue 920 in ccpp-physics
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
opt_sfc=4 will be used for some regional RTs. Results will be changed.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
This PR is to add MYNN surface scheme as opt_sfc=4 in NoahMP and recode the thermal roughness scheme as a subroutine. A bug with opt_sfc=1 was fixed. 2m T/Q from NoahMP instead of sfc_diag will be used as outputs.
The update is not aimed for UFS coupled prototype 8, but for RRFS.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs