Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions to repair iovr=5 cloud overlap option #1025

Merged
merged 18 commits into from
Jan 31, 2022
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
[submodule "FV3"]
path = FV3
url = https://github.com/NOAA-EMC/fv3atm
branch = develop
url = https://github.com/grantfirl/fv3atm
branch = iovr5_repair
#url = https://github.com/NOAA-EMC/fv3atm
#branch = develop
[submodule "WW3"]
path = WW3
url = https://github.com/NOAA-EMC/WW3
Expand Down
2 changes: 1 addition & 1 deletion FV3
628 changes: 314 additions & 314 deletions tests/RegressionTests_cheyenne.gnu.log

Large diffs are not rendered by default.

1,972 changes: 1,008 additions & 964 deletions tests/RegressionTests_cheyenne.intel.log

Large diffs are not rendered by default.

1,998 changes: 1,021 additions & 977 deletions tests/RegressionTests_gaea.intel.log

Large diffs are not rendered by default.

630 changes: 315 additions & 315 deletions tests/RegressionTests_hera.gnu.log

Large diffs are not rendered by default.

2,010 changes: 1,027 additions & 983 deletions tests/RegressionTests_hera.intel.log

Large diffs are not rendered by default.

1,870 changes: 957 additions & 913 deletions tests/RegressionTests_jet.intel.log

Large diffs are not rendered by default.

2,012 changes: 1,028 additions & 984 deletions tests/RegressionTests_orion.intel.log

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/parm/control.nml.IN
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ deflate_level=1
iems = 1
iaer = @[IAER]
icliq_sw = 2
iovr = 3
iovr = @[IOVR]
ico2 = 2
isubc_sw = 2
isubc_lw = 2
Expand Down
2 changes: 2 additions & 0 deletions tests/rt.conf
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ RUN | control_c384gdas
RUN | control_stochy | | fv3 |
RUN | control_stochy_restart | | | control_stochy
RUN | control_lndp | | fv3 |
RUN | control_iovr4 | | fv3 |
RUN | control_iovr5 | | fv3 |

RUN | control_p8 | | fv3 |
RUN | control_restart_p8 | | | control_p8
Expand Down
2 changes: 1 addition & 1 deletion tests/rt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ if [[ $TESTS_FILE =~ '35d' ]] || [[ $TESTS_FILE =~ 'weekly' ]]; then
TEST_35D=true
fi

BL_DATE=20220121
BL_DATE=20220128
if [[ $MACHINE_ID = hera.* ]] || [[ $MACHINE_ID = orion.* ]] || [[ $MACHINE_ID = cheyenne.* ]] || [[ $MACHINE_ID = gaea.* ]] || [[ $MACHINE_ID = jet.* ]] || [[ $MACHINE_ID = s4.* ]]; then
RTPWD=${RTPWD:-$DISKNM/NEMSfv3gfs/develop-${BL_DATE}/${RT_COMPILER^^}}
else
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3
export OUTPUT_FH='0 21 24'


Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_2threads
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3

export THRD=2
export TASKS=$TASKS_thrd
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_2threads_debug
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export SHOUR=06
export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export IAER=5111
export IOVR=3
export FHMAX=01
export OUTPUT_FH="0 1"

Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_CubedSphereGrid
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export RESTART_INTERVAL=0
export OUTPUT_GRID='cubed_sphere_grid'
export NSTF_NAME='2,0,0,0,0'
export IAER=5111
export IOVR=3

export WRITE_DOPOST=.false.

Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_CubedSphereGrid_debug
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export FHMAX=1
export OUTPUT_GRID='cubed_sphere_grid'
export NSTF_NAME='2,0,0,0,0'
export IAER=5111
export IOVR=3
export OUTPUT_FH="0 1"

export FV3_RUN=control_run.IN
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_atm_aerosols
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3
export FSCAV_AERO='"*:0.6", "seas1:1.0", "seas2:1.0", "seas3:1.0", "seas4:1.0", "seas5:1.0"'
export DNATS=3

Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_atmwav
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3

export FHMAX=12
#wave
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_c192
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3
export IMO=768
export JMO=384

Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_c384
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3
export IMO=1536
export JMO=768
export OUTPUT_FH="6 -1"
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_c48
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.false.
export OUTPUT_FH="6 -1"
export IAER=5111
export IOVR=3
export IMO=192
export JMO=94

Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_c768
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export OUTPUT_FILE="'netcdf_parallel' 'netcdf_parallel'"
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3
export IMO=3072
export JMO=1536
export IDEFLATE=1
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_debug
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export SHOUR=06
export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export IAER=5111
export IOVR=3
export FHMAX=1
export OUTPUT_FH="0 1"
#export WRITE_DOPOST=.true.
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_decomp
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3

export INPES=6
export JNPES=4
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_diag_debug
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export SHOUR=06
export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export IAER=5111
export IOVR=3
export FHMAX=1
export OUTPUT_FH="0 1"

Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_fhzero
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3
export FHZERO=3
export OUTPUT_FH='0 21'

Expand Down
42 changes: 42 additions & 0 deletions tests/tests/control_iovr4
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
###############################################################################
#
# global control test: GFSv16 atmosphere only at C96L127 using cloud overlap option iovr=4
#
###############################################################################

export TEST_DESCR="Compare global control using iovr=4 results with previous trunk version"

export CNTL_DIR=control_iovr4

export LIST_FILES="sfcf000.nc \
sfcf021.nc \
sfcf024.nc \
atmf000.nc \
atmf021.nc \
atmf024.nc \
GFSFLX.GrbF00 \
GFSFLX.GrbF21 \
GFSFLX.GrbF24 \
GFSPRS.GrbF00 \
GFSPRS.GrbF21 \
GFSPRS.GrbF24"

export_fv3
export NPZ=127
export NPZP=128
export DT_ATMOS=720
export SYEAR=2021
export SMONTH=03
export SDAY=22
export SHOUR=06
export RESTART_INTERVAL="12 -1"
export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export OUTPUT_FH='0 21 24'
export IOVR=4

export FV3_RUN=control_run.IN
export CCPP_SUITE=FV3_GFS_v16
export INPUT_NML=control.nml.IN
42 changes: 42 additions & 0 deletions tests/tests/control_iovr5
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
###############################################################################
#
# global control test: GFSv16 atmosphere only at C96L127 using cloud overlap option iovr=5
#
###############################################################################

export TEST_DESCR="Compare global control using iovr=5 results with previous trunk version"

export CNTL_DIR=control_iovr5

export LIST_FILES="sfcf000.nc \
sfcf021.nc \
sfcf024.nc \
atmf000.nc \
atmf021.nc \
atmf024.nc \
GFSFLX.GrbF00 \
GFSFLX.GrbF21 \
GFSFLX.GrbF24 \
GFSPRS.GrbF00 \
GFSPRS.GrbF21 \
GFSPRS.GrbF24"

export_fv3
export NPZ=127
export NPZP=128
export DT_ATMOS=720
export SYEAR=2021
export SMONTH=03
export SDAY=22
export SHOUR=06
export RESTART_INTERVAL="12 -1"
export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export OUTPUT_FH='0 21 24'
export IOVR=5

export FV3_RUN=control_run.IN
export CCPP_SUITE=FV3_GFS_v16
export INPUT_NML=control.nml.IN
1 change: 1 addition & 0 deletions tests/tests/control_latlon
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export JMO=181
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3
export OUTPUT_FH='0 24'


Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_ras
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3

export RAS=.true.
export IMFDEEPCNV=-1
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_ras_debug
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export FHMAX=1
export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export IAER=5111
export IOVR=3
export OUTPUT_FH="0 1"

export RAS=.true.
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_restart
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3
export FHROT=12

export WARM_START=.true.
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_stochy
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export OUTPUT_FH='6 -1'
export IAER=5111
export IOVR=3
export DO_SPPT=.true.
export DO_SHUM=.true.
export DO_SKEB=.true.
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_stochy_debug
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export FHMAX=1
export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export IAER=5111
export IOVR=3
export OUTPUT_FH="0 1"
export DO_SPPT=.true.
export DO_SHUM=.true.
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_stochy_restart
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3
export FHROT=06
export OUTPUT_FH="3 -1"

Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_wrtGauss_netcdf_parallel
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export WRITE_DOPOST=.true.
export IAER=5111
export IOVR=3
export OUTPUT_FILE="'netcdf_parallel' 'netcdf_parallel'"
export IDEFLATE=1
export NBITS=14
Expand Down
1 change: 1 addition & 0 deletions tests/tests/control_wrtGauss_netcdf_parallel_debug
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export FHMAX=1
export OUTPUT_GRID='gaussian_grid'
export NSTF_NAME='2,0,0,0,0'
export IAER=5111
export IOVR=3
export OUTPUT_FILE="'netcdf_parallel' 'netcdf_parallel'"
export IDEFLATE=1
export NBITS=14
Expand Down