-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Introduce test cases from ufs-case-studies platform thru WE2E #822
[develop] Introduce test cases from ufs-case-studies platform thru WE2E #822
Conversation
The 2020_CAD experiment passed on Cheyenne intel for me, but I had to manually get the initial conditions as the |
Thanks for testing, Ed. Good catch. Normally on compute node you do not have access to internet. I have tested 2020_CAD experiment on Hera, Orion, and Gaea. Hera and Orion have service partition so you can submit jobs with internet access. Gaea has specific nodes to allow you do data transfer and the associated changes have been included in this PR. Unfortunately I do not have access of Jet and Cheyenne, but I guess they may have similar partitions? @MichaelLueken do you have any inputs? |
@clouden90 I can't speak on Cheyenne, but looking through the coverage and functional tests on Jet, there shouldn't be an issue pulling data from HPSS or AWS. We will likely need to stage data on Cheyenne if we want to run these tests on that machine, but there are get_from_HPSS and get_from_AWS tests run on Jet (and Hera), so that shouldn't be an issue. I'm currently working on testing this PR on Jet and will let you know if I encounter this issue as well. |
@clouden90 In the
The test is running without isue for me on Jet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clouden90 These changes look good to me!
I was able to successfully run the new 2020_CAD test on Jet. I wouldn't expect the new test to work on Cheyenne, you need to pre-stage data on that machine, but the rest of the machines should be able to pull the necessary data from AWS. So, while I will give my approval, I'd like to see if @EdwardSnyder-NOAA is still encountering issues with running the test on Hera, Jet, or Orion.
I was able to get data on Jet now, so not sure what went wrong the first time. Are we wanting this test to run on Cheyenne? If so, we should pre-stage the data there, which is something I can help with. I'll approve the PR once the data is staged or if the decision is to not to run this on Cheyenne. |
@EdwardSnyder-NOAA: Thanks for testing, and I'm glad to hear that you can now pass the test on Jet. Ideally, it would be great if we could make this test work on all the Tier 1 NOAA machines, including Cheyenne. Please note that the end date for this specific deliverable is 6/23. Do you think it's possible to have the pre-staged data ready on Cheyenne before that? In the meantime, I can add a note in the test config YAML file to notify users that this test will require pre-staged data on Cheyenne. Does this sound good? |
@clouden90 - Yeah, we can pre-stage the data by then. It looks like this data is FV3GFS, so I'll place it with the other case/test input model data here: |
@clouden90 Before this PR is merged, since @EdwardSnyder-NOAA is working on staging the data on Cheyenne for the new test, the new 2020_CAD test should be added to the |
Thanks @EdwardSnyder-NOAA for the support! Since I do not have account on Cheyenne, would you mind to re-do the test on Cheyenne once the pre-staging data is ready? Thanks |
The data has been staged on Cheyenne and the test passed successfully. These are the changes (highlighted by **) I made to the
|
@EdwardSnyder-NOAA , Thanks again for staging data on Cheyenne and sharing the changes! I will add a note in the description section to include your modifications for users who are interested in running this test on Cheyenne. |
@EdwardSnyder-NOAA Unfortunately, if the @clouden90 Following the update to the develop branch this morning, there is now a conflict in |
@MichaelLueken , thanks! I have merged the latest develop, and add 2020_CAD test to comprehensive.orion and coverage.orion. Also @EdwardSnyder-NOAA suggestions are added as a note in description session for users who are interested in running this test on Cheyenne. |
@EdwardSnyder-NOAA , as @MichaelLueken mentioned, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding that note! LGTM.
@clouden90 The Jenkins automated tests passed on Cheyenne, Hera, and Jet. The tests failed on Orion due to the inability to clone the ccpp-physics repository (a known issue that requires git/2.28.0 to be loaded in the .bashrc file on the machine before the tests can run). I am currently running the Jenkins tests manually on Orion. Once they are complete, I will move forward with merging this PR. |
@clouden90 The manual submission of the Jenkins tests on Orion have all passed. Moving forward with merging this PR now.
|
The reference of CCPP-SCM was missing in PR #822. Here, we add it back.
DESCRIPTION OF CHANGES:
The UFS Case Studies Platform provides a set of cases that reveal the forecast challenges of NOAA's operational Global Forecast System (GFS). Here we introduce one of these cases: [2020 Cold Air Damming](2020 Cold Air Damming) into UFS SRW thru WE2E testing framework. A yaml config file is added and moderate modifications are done for
exregional_get_extrn_mdl_files.sh
. This new function allows users to run any test cases from UFS Case Studies Platform directly thru WE2E framework without need of additional steps (e.g. download ICS/LBCS data from platform first). User can still modify the yaml file to suit their needs (e.g. increase fcst time, play with different grid resolution or CCPP suite).Additionally, we added CCPP-SCM user and technical guide as a reference in Section 8.2 for users who are interested in running single column model.
Type of change
TESTS CONDUCTED:
On Level 1 systems,
git clone
the feature branch, navigate to theufs-srweather-app
folder, and check out the external repositories. Then navigate totests
folder and follow the instruction below:The modeled T2M were compared with RAP analysis, and the conclusions are consistent with the results shown here
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR: