[develop] Update modulefiles to use spack-stack unified environment #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkflow env. that breaks run_post (at least) due to conflict with stack python. Everything is handled directly by UE py modules. Minor modulefile changes.
Revert ufs-wm external to hash b388eb9.
… Jet's wflow file.
MichaelLueken
changed the title
MichaelLueken
added
enhancement
willmayfield
pushed a commit
to willmayfield/ufs-srweather-app
that referenced
this pull request
May 1, 2023
…ity#740) ## DESCRIPTION OF CHANGES: The script/function `get_WE2Etest_names_subdirs_descs.sh` (which is called from `run_WE2E_tests.sh` if needed) creates a CSV (Comma-Separated Value) file named `WE2E_test_info.csv` that contains information about the WE2E tests. Currently, this CSV file contains only 3 columns: the test name, the names of any alternate names for the test, and the test description. In order to have a more complete summary of the WE2E tests, this PR modifies `get_WE2Etest_names_subdirs_descs.sh` so that additional information is included in the CSV file. This additional information consists of the values of the following experiment variables for each test: ``` PREDEF_GRID_NAME CCPP_PHYS_SUITE EXTRN_MDL_NAME_ICS EXTRN_MDL_NAME_LBCS DATE_FIRST_CYCL DATE_LAST_CYCL CYCL_HRS INCR_CYCL_FREQ FCST_LEN_HRS LBC_SPEC_INTVL_HRS NUM_ENS_MEMBERS ``` In addition, the script uses this information to calculate the number of times each test calls the forecast model (e.g. if the test uses 3 different cycle dates, then the forecast model will be called 3 times; if it is an ensemble test for a single cycle, the test will call the forecast model as many times as the number of ensemble members). ## TESTS CONDUCTED: The script `run_WE2E_tests.sh` was called that in turn calls `get_WE2Etest_names_subdirs_descs.sh`. This created a new CSV file that contained the new fields (columns). The CSV file was imported into Google Sheets (using "|" as the field/column separator) and looked correct. ## DOCUMENTATION: The documentation is for the most part already within the `get_WE2Etest_names_subdirs_descs.sh`. This PR slightly modifies that documentation to update it.
|
Another updated PR #913 is currently open for updating SRW to use spack-stack modules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
This is currently work in progress meant to update the SRW modulefiles to use spack-stack unified environment. This relates to #572.
As spack-stack/1.3.0 has been released and the spack-stack Unified Environment (UE) has been installed on all supported platforms, modulefiles for these machines should be updated to use spack-stack in place of hpc-stack. A similar effort is being made in the UFS-WM with PR #1707, which should be updated/merged before adoption in the SRW. UE installation and (some) testing information can be found here
Currently, Cheyenne, Hera, Orion, Jet, Gaea and noaacloud modulefiles have been changed; the remaining machine updates will be committed in the near term.
srw_commonwill need to be updated to use the module versions included in the UE (which are at least up-to-date or newer than the currentsrw_commonmodules). For now, ansrw_common_spackmodule is used for testing.Some additional modifications may be required (a few beta modifications are currently committed) for certain platforms outside of the modulefiles, such as in the machine files and various workflow scripts (e.g., due to MPI changes from mpich/MPT to impi/openmpi on some platforms). Further, due to conflicts with the current regional_workflow miniconda environment and the Python/miniconda used to build (and included as a meta-module within) spack-stack, the
wflow_*modulefiles have been changed, but there is probably a better solution for this. In the meantime, all necessary Python packages pertinent to the regional_workflow are provided by loadingufs-pyenv(included w/ spack-stack UE) in thewflow_*modulefiles.So far, this has been tested on Orion, Jet, Gaea, Hera, and Cheyenne (see #572, or spack-stack #503), but WE2E tests will be run on all supported machines in the coming week or so (with results to be reported here).
Community testing of the SRW against the spack-stack ue is highly encouraged and appreciated! Also, any and all feedback would be very much appreciated!
Type of change
TESTS CONDUCTED:
Fundamental WE2E tests were run on Orion, Cheyenne, Jet, Hera, and noaacloud. Testing on the other platforms is underway and status will be reported on here.
/scratch1/NCEPDEV/stmp4/Cameron.Book/srw_ue/tests/WE2E/fundamental.intel/work2/noaa/epic-ps/cbook/ue_srw_testing/OUE/cbSRW_testUE/tests/fundamental.orion_tests/glade/scratch/bcameron/sw/test_ue/run_post_debug/tests/WE2E/run_post_testsfailure in run_post/lustre/f2/dev/Cameron.Book/srw_ue/tests/WE2E/fundamental_gaea/lfs4/HFIP/hfv3gfs/Cameron.Book/sw/cbSRW-testUE/tests/WE2E/ue_intelDEPENDENCIES:
None, except ufs-community/ufs-weather-model#1707
DOCUMENTATION:
ISSUE:
#572
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):