Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Update ufs-weather-model and UPP hash to correct post control file issue #699

Merged

Conversation

MichaelLueken
Copy link
Collaborator

DESCRIPTION OF CHANGES:

In the update to the ufs-srweather-app at e317d02, changes were required to allow the run_post tasks to complete for GNU compilers. The version of the ufs-weather-model associated with this hash was b388eb9 and with a UPP hash of b37f8ab.

During the bi-weekly UFS app and component coordination meeting, I was told that the latest update to the ufs-weather-model, from earlier that morning, updated UPP and corrected issues associated with the post control file. The ufs-weather-model hash has been updated to 36d6e16 (March 24, 2023) and the UPP hash has been updated to 22cfb88 (March 22, 2023). The changes required to allow the previous versions of ufs-weather-model and UPP were removed. The fundamental WE2E tests were run using the updated hashes on Cheyenne (both GNU and Intel) and successfully passed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • cheyenne.intel
    (also tested inline_post WE2E test)
  • cheyenne.gnu
    (also tested inline_post WE2E test)
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

ISSUE:

Fixes #697

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

CONTRIBUTORS (optional):

@SamuelTrahanNOAA and @WenMeng-NOAA for letting me know about the latest modification to the weather model associated with bug fixes for UPP.

…ests. Following the migration to the new VPN Jenkins site, Jenkins is no longer able to communicate with either Hera or Jet. Will return Jet once the machine is comunicating properly with Jenkins again.
@MichaelLueken
Copy link
Collaborator Author

@chan-hoo and @danielabdi-noaa Thank you very much for reviewing and approving these changes!

I have just pushed another update related to the Jenkins tests. Following the migration to the new VPN Jenkins site last Friday (March 24, 2023), communication between Jenkins and Hera/Jet has been lost. This last update will temporarily remove Jet from the machines to run the automated tests on. Once the new EPIC allocation is setup on Hera and both Hera and Jet are able to communicate with Jenkins again, these two machines will be brought back.

@MichaelLueken MichaelLueken added run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests ci-hera-intel-WE Kicks off automated workflow test on hera with intel labels Mar 27, 2023
@venitahagerty venitahagerty removed the ci-hera-intel-WE Kicks off automated workflow test on hera with intel label Mar 28, 2023
@venitahagerty
Copy link
Collaborator

Machine: hera
Compiler: intel
Job: WE
Repo location: /scratch1/BMC/zrtrr/rrfs_ci/autoci/pr/1291671532/20230328160512/ufs-srweather-app
Build was Successful
Rocoto jobs started
Experiment done: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
2023-03-29 12:05:29 +0000 :: hfe07 :: This cycle is complete: Success
Experiment done: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
2023-03-29 12:05:37 +0000 :: hfe07 :: This cycle is complete: Success
Experiment failed: MET_ensemble_verification
2023-03-29 12:12:45 +0000 :: hfe07 :: Task run_MET_PcpCombine_fcst_APCP06h_mem001, jobid=43353054, in state DEAD (FAILED), ran for 13.0 seconds, exit status=256, try=2 (of 2)
Experiment failed: MET_ensemble_verification
2023-03-29 12:12:45 +0000 :: hfe07 :: Task run_MET_PcpCombine_fcst_APCP03h_mem002, jobid=43353055, in state DEAD (FAILED), ran for 18.0 seconds, exit status=256, try=2 (of 2)
Experiment failed: MET_ensemble_verification
2023-03-29 12:12:45 +0000 :: hfe07 :: Task run_MET_PcpCombine_fcst_APCP06h_mem002, jobid=43353056, in state DEAD (FAILED), ran for 16.0 seconds, exit status=256, try=2 (of 2)
Experiment failed: MET_ensemble_verification
2023-03-29 12:12:46 +0000 :: hfe07 :: Task run_MET_PcpCombine_fcst_APCP03h_mem001, jobid=43353053, in state DEAD (FAILED), ran for 19.0 seconds, exit status=256, try=2 (of 2)
Experiment failed: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
2023-03-29 11:56:23 +0000 :: hfe07 :: Task run_fcst, jobid=43348498, in state DEAD (FAILED), ran for 73.0 seconds, exit status=256, try=1 (of 1)
Experiment done: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
2023-03-29 12:05:09 +0000 :: hfe07 :: This cycle is complete: Success
Experiment done: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
2023-03-29 12:04:16 +0000 :: hfe07 :: This cycle is complete: Success
Experiment done: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional_plot
2023-03-29 12:09:05 +0000 :: hfe07 :: This cycle is complete: Success
Experiment done: pregen_grid_orog_sfc_climo
2023-03-29 11:56:48 +0000 :: hfe07 :: This cycle is complete: Success
Experiment done: community_ensemble_2mems_stoch
2023-03-29 12:05:20 +0000 :: hfe07 :: This cycle is complete: Success
Experiment done: grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2
2023-03-29 12:05:34 +0000 :: hfe07 :: This cycle is complete: Success
If test failed, please make changes and add the following label back:
ci-hera-intel-WE

@MichaelLueken
Copy link
Collaborator Author

The MET_ensemble_verification failure is due to issue #688 and the grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR failure is due to issue #652. Moving forward with merging this work now.

@MichaelLueken MichaelLueken merged commit aa9841c into ufs-community:develop Mar 29, 2023
@MichaelLueken MichaelLueken deleted the feature/WM-hash-update branch May 8, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ufs-weather-model and UPP hashes so that post control file can be used directly from UPP repository
4 participants