[develop] correct SINGULARITY_TEMPDIR -> SINGULARITY_TMPDIR #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct environment variable for Singularity to use a temporary directory is SINGULARITY_TMPDIR See: https://docs.sylabs.io/guides/3.11/user-guide/build_env.html#temporary-folders
dtrudg
requested review from
mkavulich,
gsketefian,
JeffBeck-NOAA,
RatkoVasic-NOAA,
BenjaminBlake-NOAA,
ywangwof,
chan-hoo,
panll,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
mark-a-potts,
jkbk2004,
willmayfield,
dmwright526,
gspetro-NOAA,
natalie-perlin,
EdwardSnyder-NOAA and
MichaelLueken
as code owners
MichaelLueken
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
@dtrudg Thank you very much for correcting this so issue within the ufs-srweather-app's documentation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
The correct environment variable for Singularity to use a temporary directory is SINGULARITY_TMPDIR, not SINGULARITY_TEMPDIR.
See: https://docs.sylabs.io/guides/3.11/user-guide/build_env.html#temporary-folders
We are getting bug reports in the SingularityCE repository due to the incorrect value in this guide.
sylabs/singularity#1339
Type of change
TESTS CONDUCTED:
None required
ISSUE:
Related to sylabs/singularity#1339
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):