-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Adding SPFH to Metplus config file #552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @linlin-pan, thanks for adding specific humidity to the verification! I only see 2-m SPFH at the moment, though.
The upper air part is already included in file PointStat_upper_air.conf. Thanks @JeffBeck-NOAA ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panll I was able to clone your fork on Cheyenne and run the MET_verification test. I was able to see the new SPFH Z2 entries in the sfc
file. I also saw several SPFH entries in the upa
file. Out of curiosity, was there a reason why SPFH was added to upper_air
, but not sfc
?
I will go ahead and approve this this PR, though it might be an idea to change the title of this PR from Adding SPFH to Metplus config file
to Adding SPFH to Metplus sfc config file
.
Thanks! @MichaelLueken SPFH is missed in sfc file (PointStat_conus_sfc.conf), so this pull request adds SPFH to the sfc file (PointStat_conus_sfc.conf) . In upper file (e.g., PointStat_upper_air.conf), SPFH has already existed. Thus no change is made to the upper file. |
Thank you, @linlin-pan! Approving now. |
DESCRIPTION OF CHANGES:
Adding specific humidity (SPFH) to Metplus config file for verification.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
None
DOCUMENTATION:
N/A
ISSUE:
N/A
CHECKLIST
The change only relate to METPLUS configuration file.