Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Gaea pregenerated domain files path. #522

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

christinaholtNOAA
Copy link
Collaborator

@christinaholtNOAA christinaholtNOAA commented Dec 20, 2022

DESCRIPTION OF CHANGES:

Gaea only has TEST_PREGEN_BASEDIR set, and should also set DOMAIN_PREGEN_BASEDIR. Also, in the WE2E testing framework, run_WE2E_tests.sh sets GRID_DIR, SFC_CLIMO_DIR, and OROG_DIR using TEST_PREGEN_BASEDIR, but should also set DOMAIN_PREGEN_BASEDIR for consistency.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

Currently running Hera fundamental tests to check mods to run_WE2E_tests.sh, but I cannot run on gaea.

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

ISSUE:

n/a

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

Use TEST_PREGEN_BASEDIR to set DOMAIN_PREGEN_BASEDIR if provided for a
machine.
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christinaholtNOAA These changes look good to me! I was also able to successfully run both the standard fundamental WE2E tests and the Jenkins fundamental tests on Gaea. Approving this work.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Jan 3, 2023
@MichaelLueken MichaelLueken merged commit d3d023b into ufs-community:develop Jan 6, 2023
@christinaholtNOAA christinaholtNOAA deleted the gaea_pregen branch December 8, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants