-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Ensure arbitrary restart_interval numbers in model_configure #503
[develop] Ensure arbitrary restart_interval numbers in model_configure #503
Conversation
@MichaelLueken, Thank you! I forgot to add [develop] to the title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chan-hoo These changes look good to me. However, the specify_RESTART_INTERVAL WE2E test was ran on Cheyenne. This test failed due to running over the walltime limit. Please increase WTIME_RUN_FCST:
to allow the test to run on this machine (01:30:00 or 02:00:00 should allow this test to run to completion).
tests/WE2E/test_configs/wflow_features/config.specify_RESTART_INTERVAL.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, @chan-hoo, for addressing my concern! A rerun of the specify_RESTART_INTERVAL
test on Cheyenne is now successfully passing. Approving this work and launching the Jenkins tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have run the test case modified in this PR on Hera, and it does produce restart files for forecast hours 1, 2 and 5 so approving.
The Jenkins tests have passed, two approvals have been given, and there are no outstanding comments, so I will now move forward with merging this work. |
DESCRIPTION OF CHANGES:
restart_interval
, the unnecessary parameter value-1
is removed from the templateparm/model_configure
.restart_interval: 1 2 5
, which creates the restart files at fhr=1, 2, and 5.Type of change
TESTS CONDUCTED:
ISSUE:
Fixes issue mentioned in #502
CHECKLIST