Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop]: Updated the .github/CODEOWNERS file #361

Merged

Conversation

MichaelLueken
Copy link
Collaborator

DESCRIPTION OF CHANGES:

As the EPIC code manager for the ufs-srweather-app repo, my GitHub username needs to be added to the ./github/CODEOWNERS file. In my fork's branch, text/update-CODEOWNERS-file, I have added my GitHub username to the .github/CODEOWNERS file.

Please note that this is also a test to see if I can successfully merge PRs back to the authoritative repo. Once this PR is approved, please let me try merging it to the authoritative repo.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to text file
  • This change requires a documentation update

TESTS CONDUCTED:

None required

ISSUE:

Fixes issue mentioned in #360

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link
Collaborator

@JeffBeck-NOAA JeffBeck-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MichaelLueken MichaelLueken merged commit cecc90e into ufs-community:develop Sep 21, 2022
@MichaelLueken MichaelLueken deleted the text/update-CODEOWNERS-file branch September 21, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants