Pylint in GitHub Actions test isn't compatible with on-prem environments #787
Assignees
Labels
bug
Something isn't working
Comments
This was referenced May 10, 2023
26 tasks
michelleharrold
pushed a commit
to michelleharrold/ufs-srweather-app
that referenced
this issue
Jun 7, 2023
…ity#787) ## DESCRIPTION OF CHANGES: For clarity, rename variables related to GFDLgrid-type grids: 1) Rename `GFDLgrid_RES` to `GFDLgrid_NUM_CELLS`. 2) Rename `GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES` to `GFDLgrid_USE_NUM_CELLS_IN_FILENAMES`. 3) Rename WE2E tests on GFDLgrid-type custom grids according to variable renaming above. Related improvements: * In `link_fix.sh`, remove creation of unnecessary symlink when using a GFDLgrid-type grid with `GFDLgrid_USE_NUM_CELLS_IN_FILENAMES` is set to `"FALSE"`. * In WE2E test configuration files that use custom grids, move the definition of the variable `POST_OUTPUT_DOMAIN_NAME` to the beginning of the custom grid definition because it is really the name of the custom native grid, and it's most appropriate to place that at the beginning of the grid definition section. * Reduce `WTIME_MAKE_OROG` from 1 hour to 20 minutes since on Hera, 1 hour causes the task to wait quite a while in the queue. This used to be 20 minutes but was changed to 1 hour because 20 minutes was not sufficient to complete the task on `WCOSS_DELL_P3`. Thus, reset it to 1 hour only in the machine file for `WCOSS_DELL_P3`. * Minor fixes to comments in python plotting scripts. * Edits to other comments. ## TESTS CONDUCTED: Ran the four WE2E tests that use custom grids (listed below) on Hera. All were successful. * `custom_ESGgrid` * `custom_GFDLgrid` * `custom_GFDLgrid__GFDLgrid_USE_NUM_CELLS_IN_FILENAMES_eq_FALSE` (previously `custom_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE`) * `custom_GFDLgrid__GFDLgrid_USE_NUM_CELLS_IN_FILENAMES_eq_TRUE` (previously `custom_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_TRUE`) ## DEPENDENCIES: PR #[310](ufs-community#310) in `ufs-srweather-app`. ## DOCUMENTATION: Updates to documentation are in PR #[310](ufs-community#310) in `ufs-srweather-app`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
Running
pylint tests/test_pythonin the GitHub Actions workflow should give the same results as when running the same command on supported conda environments on Tier I platforms, all resulting in a linter score of 10/10.Current behavior
The newer version of pylint on-prem results in a much lower score, and not the same sorts of behaviors as GitHub Actions reports. It's impossible to accurately debug locally before pushing to GitHub.
Detailed Description of Fix (optional)
Bump the pylint version in GitHub Actions to consistent with the one in regional_workflow on Jet/Hera, and ensure the code is updated to pass the new version at 10/10.
The text was updated successfully, but these errors were encountered: