Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cmake build for EMC_post #7

Closed
3 of 4 tasks
mkavulich opened this issue May 28, 2020 · 1 comment · Fixed by #27
Closed
3 of 4 tasks

Use cmake build for EMC_post #7

mkavulich opened this issue May 28, 2020 · 1 comment · Fixed by #27
Assignees

Comments

@mkavulich
Copy link
Collaborator

mkavulich commented May 28, 2020

  • Point to EMC_post hash that builds with cmake
  • Test building and running
  • Merge EMC_post cmake build to develop
  • Change srweather-app to point to hash in EMC_post on develop with final merged changes
@mkavulich mkavulich self-assigned this May 28, 2020
@jwolff-ncar
Copy link
Collaborator

@mkavulich Should this be handled in issue #5 or should this remain separate?

@mkavulich mkavulich linked a pull request Oct 8, 2020 that will close this issue
mkavulich added a commit that referenced this issue Oct 9, 2020
## DESCRIPTION OF CHANGES: 
 - Adds a CMake build using ExternalProject_Add.
 - Makes modifications to build_all.sh and install_all.sh for back-compatibility with old build system. The old build system will remain in, but is now deprecated, and will be removed in the coming weeks.

To build, have the necessary modules loaded and run:

```
mkdir build
cd build
cmake .. -DCMAKE_INSTALL_PREFIX=<prefix>
make
```

The docs/ directory contains README files with instructions for specific platforms/compilers

## TESTS CONDUCTED: 
 - **Cheyenne**: Build and end-to-end test ("DOT_OR_USCORE" test case) was successful on Cheyenne with intel, both for the cmake build and the old build script (that will soon be deprecated). Path to tests: /glade/scratch/kavulich/UFS_CAM/testing/SRW_PR_27/expt_dirs/
 - **Hera**: Build and end-to-end tests successful (aside from expected failures). Path to tests: /scratch2/BMC/det/kavulich/workdir/SRW_PR_27/expt_dirs
 - **Jet**: Build test was successful. 

## ISSUE: 
Resolves #7, partially resolves #5 

Co-authored-by: kgerheiser <[email protected]>; Michael Kavulich, Jr <[email protected]>
mkavulich added a commit that referenced this issue Oct 9, 2020
 - Adds a CMake build using ExternalProject_Add.
 - Makes modifications to build_all.sh and install_all.sh for back-compatibility with old build system. The old build system will remain in, but is now deprecated, and will be removed in the coming weeks.

To build, have the necessary modules loaded and run:

```
mkdir build
cd build
cmake .. -DCMAKE_INSTALL_PREFIX=<prefix>
make
```

The docs/ directory contains README files with instructions for specific platforms/compilers

 - **Cheyenne**: Build and end-to-end test ("DOT_OR_USCORE" test case) was successful on Cheyenne with intel, both for the cmake build and the old build script (that will soon be deprecated). Path to tests: /glade/scratch/kavulich/UFS_CAM/testing/SRW_PR_27/expt_dirs/
 - **Hera**: Build and end-to-end tests successful (aside from expected failures). Path to tests: /scratch2/BMC/det/kavulich/workdir/SRW_PR_27/expt_dirs
 - **Jet**: Build test was successful.

Resolves #7, partially resolves #5

Co-authored-by: kgerheiser <[email protected]>; Michael Kavulich, Jr <[email protected]>
MichaelLueken pushed a commit to MichaelLueken/ufs-srweather-app that referenced this issue Jan 18, 2024
Disable comprehensive tests on Derecho that fail due to issues in UF_UTILS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants