Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Fix WE2E yaml configuration file for MET_verification_only_vx #608

Closed
gsketefian opened this issue Feb 11, 2023 · 0 comments · Fixed by #609
Closed

[develop] Fix WE2E yaml configuration file for MET_verification_only_vx #608

gsketefian opened this issue Feb 11, 2023 · 0 comments · Fixed by #609
Labels
bug Something isn't working

Comments

@gsketefian
Copy link
Collaborator

Expected behavior

The WE2E test MET_verification_only_vx should succeed.

Current behavior

Currently, MET_verification_only_vx fails because in its configuration file, the variables CCPA_OBS_DIR, MRMS_OBS_DIR, and NDAS_OBS_DIR are under the wrong section (they are under workflow_switches; they need to be under platform). The python script run_WE2E_tests.py detects this and aborts the test.

This failure was not detected earlier (i.e. when the test MET_verification_only_vx was created in PR #566) possibly because at the time local tests were conducted with a version of the App that was not updated with PR #541 and/or because the test was run with the shell script run_WE2E_tests.sh instead of its python counterpart run_WE2E_tests.py.

Machines affected

All.

Steps To Reproduce

Run the WE2E test MET_verification_only_vx using the python script run_WE2E_tests.py.

Detailed Description of Fix (optional)

In config.MET_verification_only_vx.yaml, create a new section named platform and move the variables CCPA_OBS_DIR, MRMS_OBS_DIR, and NDAS_OBS_DIR there.

@gsketefian gsketefian added the bug Something isn't working label Feb 11, 2023
@MichaelLueken MichaelLueken linked a pull request Feb 13, 2023 that will close this issue
37 tasks
MichaelLueken pushed a commit that referenced this issue Feb 17, 2023
1) Fix the bad WE2E test configuration file for MET_verification_only_vx (Issue #608).
2) Make creation of symlinks to pregenerated files depend on whether downstream tasks need those symlinks (Issue #610).
3) Set default value of FIXdir to HOMEdir/fix only when RUN_ENVIR="nco", not when RUN_TASK_MAKE_GRID=False; otherwise, set FIXdir to EXPTDIR (Issue #616).
4) Add a flag to the script get_expts_status.sh so that if an experiment hasn't been launched yet, it calls the launch script launch_FV3LAM_wflow.sh to launch it instead of only outputting a message that it's not yet launched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant