Update UFS WM to include CCPP-v6 + fixes for CI/CD #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-a-potts
requested review from
mkavulich,
gsketefian,
JeffBeck-NOAA,
RatkoVasic-NOAA,
BenjaminBlake-NOAA,
ywangwof,
chan-hoo,
panll,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
jkbk2004,
willmayfield,
dmwright526,
gspetro-NOAA,
natalie-perlin and
EdwardSnyder-NOAA
as code owners
mark-a-potts
changed the title
EdwardSnyder-NOAA
approved these changes
Jun 8, 2022
JeffBeck-NOAA
requested changes
Jun 8, 2022
JeffBeck-NOAA
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of issues related to both ci/cd and updating the UFS weather model to include CCPP-v6.
References to lndp_each_step are removed due to changes in the input.nml on the UFS-WM side.
The miniconda version is now explicitly set for jet, so that the correct conda module gets loaded.
The "location" variable in ush/machine/hera.sh has been changed so that it does not point to an rstprod directory. (Maybe there is a better solution to this?) The role account on hera does not have rstprod access, so all e2e tests there were failing to launch previously.
These changes will work in concert with ufs-srweather-app PR 293. ufs-community/ufs-srweather-app#293