Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPP to the SRW App #685
Add SPP to the SRW App #685
Changes from 46 commits
beeb04b
48bcacc
03b4aa8
abddc04
2950904
ea9f387
89eb7ba
6e4814d
61c3727
b178707
b239954
13418b7
f2bf18e
eede48a
6f4f22d
a635561
4cccb68
024e83a
988fe33
906fc90
f69f8ae
8a2f11e
d59f271
df4e097
ba7fb50
d75788c
e24cef5
3450cd2
0a9eae7
f6ee1ec
22d8dd0
89714aa
0175fb5
671ef73
9b39fa8
f098395
5130a86
95a8102
08ee469
af6d543
e4173df
eb702ef
bf82e6c
ee3957d
c799e8c
cc997ab
ed9f5a7
732999e
bc6cc28
010c1d9
05d8849
d91836e
d80dd3e
54bfd42
7599e48
4b9bde0
7b95df1
ac4ef74
ca0a8fc
45b56d9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent
settings="$settings"
line.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent
settings="$settings"
line.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issued "in" ufs-weather-model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the variables
N_VAR_LNDP
,LNDP_TYPE
, andFHCYC_LSM_SPP_OR_NOT
are used in at least one other script (generate_FV3LAM_wflow.sh
), they are not local variables. So we should treat them as experiment variables and record them invar_defns.sh
(at the end ofsetup.sh
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove tendency-based stochastic physics dissipation estimate (diss_est) from diag_table files. It doesn't exist (yet).