Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function "set_known_sys_dir" no longer exists in workflow #700

Closed
mkavulich opened this issue Mar 15, 2022 · 0 comments · Fixed by #744
Closed

Function "set_known_sys_dir" no longer exists in workflow #700

mkavulich opened this issue Mar 15, 2022 · 0 comments · Fixed by #744
Assignees
Labels
bug Something isn't working medium priority

Comments

@mkavulich
Copy link
Collaborator

Description

PR #666 (go figure) introduced a bug to the workflow generation script that produces some "command not found" error messages due to the "set_known_sys_dir" function no longer existing. It appears as if this is a harmless bug, as these function calls have been superseded by machine-specific logic elsewhere in the code due to that PR, but the calls to this non-existant function should be removed nonetheless to avoid confusion and potential future errors.

Steps to Reproduce

Run any experiment generation script on any machine for any valid config.sh file (without the "EXTRN_MDL_SYSBASEDIR_ICS" and/or "EXTRN_MDL_SYSBASEDIR_LBCS" variables set), observe the following line(s) in the output:

./set_extrn_mdl_params.sh: line 21: set_known_sys_dir: command not found
./set_extrn_mdl_params.sh: line 23: set_known_sys_dir: command not found
@mkavulich mkavulich added bug Something isn't working medium priority labels Mar 15, 2022
christinaholtNOAA added a commit to mkavulich/regional_workflow that referenced this issue Apr 20, 2022
mkavulich pushed a commit to mkavulich/regional_workflow that referenced this issue Apr 22, 2022
mkavulich pushed a commit to mkavulich/regional_workflow that referenced this issue Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium priority
Projects
None yet
2 participants