Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove USE_CCPP option #196

Closed
llpcarson opened this issue Apr 16, 2020 · 4 comments
Closed

Remove USE_CCPP option #196

llpcarson opened this issue Apr 16, 2020 · 4 comments
Assignees
@llpcarson @gsketefian
Milestone
Code Slush

Comments

@llpcarson
Copy link
Contributor

Remove the no-CCPP option (USE_CCPP=T/F) from the workflow scripts.
@llpcarson llpcarson added this to the Code Slush milestone Apr 16, 2020
@jwolff-ncar
Copy link
Contributor

@gsketefian @llpcarson Hopefully this is still on track? Would be great to have it for the code slush - which will hopefully be "any day now".

@mkavulich mkavulich mentioned this issue Oct 7, 2020
Merged
mkavulich added a commit that referenced this issue Oct 9, 2020
@mkavulich
Modifications to run workflow with unmodified executable names from e…
d79ebc3 
…ach repository (#304)

## DESCRIPTION OF CHANGES: 
The new top-level cmake build for the SRW App ([SRW App PR#27](ufs-community/ufs-srweather-app#27)) results in some executables having different names. This PR makes modifications that
 1. Allow the workflow to run successfully with the new cmake build and its different executable names, and
 2. Allow back-compatibility with the old build system to allow for a gradual transition to new build system

This PR also explicitly disallows running the workflow without CCPP, which we decided against supporting several months ago. I don't think the capability even works so this shouldn't effect anyone at this time.

## TESTS CONDUCTED: 
 - **Cheyenne**: Build and end-to-end test ("DOT_OR_USCORE" test case) was successful on Cheyenne with intel, both for the cmake build and the old build script (that will soon be deprecated). 
 - **Hera**: Build and end-to-end tests successful (aside from expected failures). Also built with old build script successfully.
 - **Jet**: Build test was successful. 

## ISSUE: 
It was not the primary aim of this PR, but it does partially resolve #196
@mkavulich
Copy link
Collaborator

Did not know that referencing this issue would close it...the USE_CCPP code is still in there in various places and should be cleaned up/removed

@mkavulich mkavulich reopened this Oct 9, 2020
@gsketefian
Copy link
Collaborator

@mkavulich I can work on this. I will start with the develop branch and make a PR. Question: Once I do that, I guess I will have to cherry-pick the squash-and-merge commit for that PR onto the HEAD of the release branch, right?

@gsketefian gsketefian mentioned this issue Oct 9, 2020
Merged
gsketefian added a commit that referenced this issue Oct 13, 2020
@gsketefian
Remove the USE_CCPP variable (#308)
3d6e1df 
## DESCRIPTION OF CHANGES:
This PR removes the USE_CCPP variable from all scripts and other files.  The workflow only supports running the FV3 model with CCPP, so USE_CCPP is deprecated.

## TESTS CONDUCTED: 
Ran one WE2E test (regional_002) on hera.  Succeeded.

## ISSUE (optional):
This resolves Issue #196.
@gsketefian
Copy link
Collaborator

This was resolved by PR #308.

gsketefian added a commit that referenced this issue Oct 15, 2020
@gsketefian
Modifications to run workflow with unmodified executable names from e…
baca537 
…ach repository (#315)

Modifications to run workflow with unmodified executable names from each repository (#304)

## DESCRIPTION OF CHANGES:
The new top-level cmake build for the SRW App ([SRW App PR#27](ufs-community/ufs-srweather-app#27)) results in some executables having different names. This PR makes modifications that
 1. Allow the workflow to run successfully with the new cmake build and its different executable names, and
 2. Allow back-compatibility with the old build system to allow for a gradual transition to new build system

This PR also explicitly disallows running the workflow without CCPP, which we decided against supporting several months ago. I don't think the capability even works so this shouldn't effect anyone at this time
.

## TESTS CONDUCTED:
 - **Cheyenne**: Build and end-to-end test ("DOT_OR_USCORE" test case) was successful on Cheyenne with intel, both for the cmake build and the old build script (that will soon be deprecated).
 - **Hera**: Build and end-to-end tests successful (aside from expected failures). Also built with old build script successfully.
 - **Jet**: Build test was successful.

## ISSUE:
It was not the primary aim of this PR, but it does partially resolve #196
gsketefian added a commit that referenced this issue Oct 15, 2020
@gsketefian
Release/public v1 feature remove use ccpp (#317)
7282f46 
## DESCRIPTION OF CHANGES:
This PR removes the USE_CCPP variable from all scripts and other files.  The workflow only supports running the FV3 model with CCPP, so USE_CCPP is deprecated.

## TESTS CONDUCTED: 
Ran one WE2E test (regional_002) on hera.  Succeeded.

## ISSUE (optional):
This resolves Issue #196.
TrevorAlcott-NOAA added a commit to TrevorAlcott-NOAA/regional_workflow that referenced this issue Sep 7, 2021
@TrevorAlcott-NOAA
Modify RRFS NA 3-km cadence to produce longer forecasts (ufs-communit…
190255e 
…y#196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llpcarson llpcarson

@gsketefian gsketefian

Labels
None yet
Projects
None yet
Milestone
Code Slush
Development

No branches or pull requests
4 participants
@llpcarson @mkavulich @jwolff-ncar @gsketefian