update GF for RRFS 2023 HWT SFE #64
Conversation
haiqinli
requested review from
grantfirl,
ChunxiZhang-NOAA and
dustinswales
as code owners
|
@haiqinli Haiqin, thank you very much for adding my change to soil parameters. |
|
@tanyasmirnova You are welcome. |
|
@grantfirl Grant, It appears that Chunxi Zhang is still automatically designated as a reviewer for may PRs and Issues. Can this the updated ? Please replace Chunxi Zhang with Qingfu Liu. |
@yangfanglin Yes. I'll updated the CODEOWNERS file and ask @haiqinli to include it in this PR. |
There was a problem hiding this comment.
Looks good. Only minor comments from me. @dustinswales @Qingfu-Liu Since this is high-priority, please review when you get a chance.
|
I just went through the code, and everything looks good. Grant already suggested the minor changes. |
|
@haiqinli Could you please merge haiqinli#1 to update the CODEOWNERS file? |
|
@grantfirl Sure, I will merge this CODEOWNERS file. |
update CODEOWNERS to replace Chunxi with Qingfu
|
All tests are done at ufs-community/ufs-weather-model#1713 @haiqinli resolve the conversations @grantfirl can you merge this pr? |
modify a few terms in vegetation diag3
1). A update of the Grell-Freitas (GF) convection for RRFS;
2). A update of RUC LSM to use BNU soil property for RRFS;
3). This is an urgent PR for RRFS 2023 HWT SFE, which will start on May 1st, 2023;
4). The regression test run has been successfully done on Hera with Intel and GNU compilers.