Winterwx #30
Merged
Winterwx #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic instead of RUC LSM, variable precip ice density optional use for NOAH MP and NOAH LSM, change radar_reset to fullradar_diag since original name did not make sense.
ericaligo-NOAA
requested review from
grantfirl and
ChunxiZhang-NOAA
as code owners
|
@ericaligo-NOAA Please add more contents for this PR. Please add what problem this PR will resolve (which issue)? How it is resolved? How it is tested? If you have PPT slides, please attach it. |
|
Okay. I simply copied and pasted the contents of the ufs-weather-model
PR to this PR. I assumed referencing my ufs-weather-model PR was enough.
…On 12/29/2022 9:36 AM, ChunxiZhang-NOAA wrote:
@ericaligo-NOAA <https://github.com/ericaligo-NOAA> Please add more
contents for this PR. Please add what problem this PR will resolve
(which issue)? How it is resolved? How it is tested? If you have PPT
slides, please attach it.
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MJMKGTQG4E3HQE5NILWPWOVDANCNFSM6AAAAAATMDBICE>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@ericaligo-NOAA I didn't see the contents you mentioned. |
|
Let me know if you need anything else.
…On 12/29/2022 11:40 AM, ChunxiZhang-NOAA wrote:
@ericaligo-NOAA <https://github.com/ericaligo-NOAA> I didn't see the
contents you mentioned.
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MMQNUGQOPVPKSBXRLDWPW5HLANCNFSM6AAAAAATMDBICE>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This was referenced Jan 1, 2023
Merged
|
I'm going to remove my name, but I will leave the comment in since these
lines were in the original RUC LSM. Not sure what the developers of the
RUC LSM want to do with these lines.
…On 1/5/2023 2:02 PM, ChunxiZhang-NOAA wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In physics/module_sf_ruclsm.F90
<#30 (comment)>:
> @@ -1494,19 +1492,19 @@ SUBROUTINE SFCTMP (debug_print, delt,ktau,conflx,i,j, & !--- input varia
!--- 27 Feb 2014 - empirical formulations from John M. Brown
! rhonewsn=min(250.,rhowater/max(4.179,(13.*tanh((274.15-Tabs)*0.3333))))
!--- 13 Mar 2018 - formulation from Trevor Elcott
- rhonewsn=min(125.,1000.0/max(8.,(17.*tanh((276.65-Tabs)*0.15))))
- rhonewgr=min(500.,rhowater/max(2.,(3.5*tanh((274.15-Tabs)*0.3333))))
- rhonewice=rhonewsn
+!aligo rhonewsn=min(125.,1000.0/max(8.,(17.*tanh((276.65-Tabs)*0.15))))
Please remove this line and the followings lines with "aligo" name.
—
Reply to this email directly, view it on GitHub
<#30 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MJZDUYXA4W43ZMPQLDWQ4LDLANCNFSM6AAAAAATMDBICE>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@ericaligo-NOAA Git will keep the old records. It is safe to remove the original lines. |
grantfirl
reviewed
Jan 10, 2023
grantfirl
reviewed
Jan 10, 2023
grantfirl
reviewed
Jan 10, 2023
grantfirl
reviewed
Jan 10, 2023
grantfirl
reviewed
Jan 10, 2023
grantfirl
reviewed
Jan 10, 2023
grantfirl
approved these changes
Jan 10, 2023
|
Okay, I'll pass rhowater into the subroutine.
…On Tue, Jan 10, 2023 at 3:25 PM Grant Firl ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/GFS_MP_generic_post.F90
<#30 (comment)>
:
> @@ -101,6 +109,10 @@ subroutine GFS_MP_generic_post_run(
real(kind=kind_phys) :: crain, csnow, onebg, tem, total_precip, tem1, tem2, ttend
real(kind=kind_phys), dimension(im) :: domr, domzr, domip, doms, t850, work1
+ real :: snowrat,grauprat,icerat,curat,prcpncfr,prcpcufr
+ real :: rhonewsnow,rhoprcpice,rhonewgr,rhonewice
+ real(kind=kind_phys), parameter :: rhowater = 1000.0_kind_phys
This constant is already defined in the host (see rhowater in
physcons.F90). You should be able to pass it in via the argument list by
using the following metadata:
[rhowater]
standard_name = fresh_liquid_water_density_at_0c
long_name = density of liquid water
units = kg m-3
dimensions = ()
type = real
kind = kind_phys
intent = in
—
Reply to this email directly, view it on GitHub
<#30 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MNKLXGS2EA266DIC7LWRXARZANCNFSM6AAAAAATMDBICE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sounds fine as long as it works properly.
…On Tue, Jan 10, 2023 at 6:03 PM Grant Firl ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/GFS_MP_generic_post.F90
<#30 (comment)>
:
> @@ -111,6 +123,68 @@ subroutine GFS_MP_generic_post_run(
rain(i) = rainc(i) + frain * rain1(i) ! time-step convective plus explicit
enddo
+! compute surface snowfall, graupel/sleet, freezing rain and precip ice density
+ if (imp_physics == imp_physics_gfdl .or. imp_physics == imp_physics_thompson .or. imp_physics == imp_physics_nssl ) then
+ do i = 1, im
+ if (gt0(i,1) .le. 273) then
+ frzr(i) = frzr(i) + rain0(i)
+ frzrb(i) = frzrb(i) + rain0(i)
+ endif
+ tsnowp(i) = tsnowp(i) + snow0(i)
+ tsnowpb(i) = tsnowpb(i) + snow0(i)
+ frozr(i) = frozr(i) + graupel0(i)
+ frozrb(i) = frozrb(i) + graupel0(i)
+ enddo
+!Compute the variable precip ice density for specific LSM schemes and options
+ if ( lsm == lsm_ruc .or. lsm == lsm_noahmp .and. iopt_snf == 5 .or. vrbliceden_noah == .true.) then
Shouldn't lsm == lsm_noahmp .and. iopt_snf == 5 be in parentheses? Maybe
not technically since AND has precedence over OR and are evaluated first,
but at least for code clarity?
—
Reply to this email directly, view it on GitHub
<#30 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MJNE4M6V3JZB4ZKXHLWRXTD3ANCNFSM6AAAAAATMDBICE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
That's fine.
…On Tue, Jan 10, 2023 at 6:16 PM Grant Firl ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/mp_thompson.meta
<#30 (comment)>
:
> @@ -610,9 +610,9 @@
type = real
kind = kind_phys
intent = out
-[reset_dBZ]
- standard_name = flag_for_resetting_radar_reflectivity_calculation
- long_name = flag for resetting radar reflectivity calculation
+[fullradar_diag]
+ standard_name = flag_for_computing_full_radar_reflectivity
how about do_full_radar_reflectivity?
—
Reply to this email directly, view it on GitHub
<#30 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MPB52ZOJZ563QMAMADWRXUS5ANCNFSM6AAAAAATMDBICE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I can switch to surface.
…On Tue, Jan 10, 2023 at 6:16 PM Grant Firl ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/GFS_MP_generic_post.meta
<#30 (comment)>
:
> @@ -278,6 +278,76 @@
type = real
kind = kind_phys
intent = inout
+[frzr]
+ standard_name = lwe_thickness_of_sfc_freezing_rain_amount
we've been spelling out surface rather than sfc, but we could include it
as an abbreviation in the rules standard name rules (
https://github.com/ESCOMP/CCPPStandardNames/blob/main/StandardNamesRules.rst)
if you feel strongly about it
—
Reply to this email directly, view it on GitHub
<#30 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MOLWP26UGKPM5GNPUDWRXTUHANCNFSM6AAAAAATMDBICE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@ericaligo-NOAA Let me know if you'd like me to make the metadata changes (here and in the fv3atm branch). I'm sure that you have better things to do (e.g. at AMS) than to worry about this. I can submit PRs into your branches with the changes that you could approve and merge. |
|
That would be great!
…On Tue, Jan 10, 2023 at 8:23 PM Grant Firl ***@***.***> wrote:
@ericaligo-NOAA <https://github.com/ericaligo-NOAA> Let me know if you'd
like me to make the metadata changes (here and in the fv3atm branch). I'm
sure that you have better things to do (e.g. at AMS) than to worry about
this. I can submit PRs into your branches with the changes that you could
approve and merge.
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MJBP5K5LAVTKYNR5ZTWRYDPPANCNFSM6AAAAAATMDBICE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
dustinswales
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
@ericaligo-NOAA I see no issues. I agree with Grant's suggestion about using the constant defined by the host.
|
@ericaligo-NOAA Please see ericaligo-NOAA#1 and ericaligo-NOAA/fv3atm#1. I may need to update these to your latest branch since you've updated your PR branch. |
OK, done updating my fv3atm PR into your PR branch so that it can safely merge. |
… use externally-calculated value
Updates for ufs/dev PR#30
ChunxiZhang-NOAA
approved these changes
Feb 15, 2023
|
@ChunxiZhang-NOAA Tests are done on ufs-community/ufs-weather-model#1529 side. please, go ahead to merge this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds six winter weather diagnostics to the FV3 history files to be read into the UPP. A variable precip ice density currently in the RUC LSM is moved to GFS_MP_generic_post.F90 with the density then passed into the RUC, NOAH and NOAH MP LSMs. The RUC LSM will use this precip ice density. The NOAH and NOAH MP LSMs have the option of using it. For NOAH, a new namlest variable is defined if the new density is to be used. For NOAH MP, an existing namelist variable is used with option 5 in order to use the new density (option 4 is default). The accumulated/continuous winter weather fields are passed into the restart files.
Also, the namelist parameter, nsradar_reset was more appropriately renamed nsfullradar_diag.
It also fixes a bug in the frequency over which the full radar reflectivity (water coated ice) is computed. With the bug, the full radar reflectivity was computed one time step before the top of the hour (when parameter was set to 3600s). The fix allows the full radar reflectivity to be computed at the top of the hour.
Issue(s) addressed
ufs-community/ufs-weather-model#1449
NOAA-EMC/UPP#568
ufs-community/ufs-weather-model#1499
Bug fix:
NOAA-EMC/fv3atm#437
PRs:
NOAA-EMC/fv3atm#614
ufs-community/ufs-weather-model#1529
Results will change for any SDF that includes the RUC LSM. Results will change if lradar=.true. because of the bug fix. Results will change since UPP expects all six diagnostics to be read in and no diag_tables were updated.
Testing
No RTs were run. Code changes were tested in a slightly older verison of ufs-weather-model in RRFS as well as global configurations. New RTs will be run on hera.
[ x] hera.intel
Dependencies
None
Issue(s) addressed
ufs-community/ufs-weather-model#1449