-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[production/RRFS.v1] fix zero cloud fraction for RRFS ensemble members #186
[production/RRFS.v1] fix zero cloud fraction for RRFS ensemble members #186
Conversation
could we have @yangfanglin @joeolson42 @JongilHan66 @haiqinli @RuiyuSun @AnningCheng-NOAA @ericaligo-NOAA to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, although do you want to combine this with #180? It would make testing/approval/merge faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine with me.
sounds good to me. The related FV3 PR is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good on its own. It took me some time to understand the difference from xr_cnvcld (flag for using suspended convective clouds in Xu Randall) introduced in PR184.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This PR was combined into #180. |
This PR will address zero cloud fraction issue for RRFS ensemble members using GFS PBL and G-F convection by adding SGS cloud to ccpp SDF and changing conv_cf_opt to Xu-Randall for convective cloud fraction computation for those members.
The change to ccpp-physics is to add conv_cf_opt as an input namelist parameter for runtime switch (conv_cf_opt=1 for GFS PBL members).
ccpp-physics issue:
#185
Several tests for a single case (init 2023/05/10/06Z) have been performed by:
Here are total/low/medium/high cloud fractions and downward short wave radiation flux at surface:
cldfra_comparison_f24.pptx
cldfra_comparison_f36.pptx
dswrfsfc.pptx