-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessarily required status code prop on _error.js page #324
Comments
nicholasio
added a commit
that referenced
this issue
Aug 2, 2020
* feat(tech): fetch a single tech by id or slug * refactor(techs): extract logic to query scope * feat(button): add info variant * feat(tech): map technology object * feat(tech): initial header design * feat(button): improve font-size * feat(tech): create provider * fix(button): proptype variants * feat(tech): useTechnology hook * refactor(tech): componentize * feat(tech): add react-tabs package * feat(tech): make it responsiveness * feat(tech): improve styles * feat(tabs): extract components * chore(deps): remove unused package * feat(tech): show data with filters * feat(tech): add optional params * style(tech): tabs content title tks @lcnogueira 🙂 * refactor(tech): rename components * style(tech): description value * style(tech): improve title container metrics * fix(tech): error when not found * style(tech): hide buttons container * chore(tech): add col wrapper to future updates * chore(tech): getInitialProps to getServerSideProps * chore(tech): code style * feat(tech): render error component when necessary * test(tech): initial fetch feature * test(tech): fix fetch and expected status * test(tech): making assertions * refactor(tech): prevent error on build move styles from dedicated file to internal component file tks @lcnogueira 👍 * style(tech): improve titles * style(tech): image shadow * style(tech): improve metrics and colors * fix: i18n namespaces with getServerSideProps tks @icrona based on i18next/next-i18next#652 * style(tech): improve margins * style(tech): fix tab title width * style(tech): improve padding * feat(helpers): unslugify * chore: remove unslugify * feat(tech): list some taxonomies * fix(edit): trying to fix tests * style(tech): improve readability * fix(home): technologies list * fix: prevent erros * refactor(tech): extract components to another path * feat(tech): only render if section has children * refactor(tabs): make props more readable * refactor(tech): styles * test(hooks): useTechnology coverage * fix(techs): error when database is empty resolver #305 * fix(techs): error when database is empty resolves #305 * test(tech): remove unnecessary data * fix(error): propTypes validation resolves #324 * tests(edit/new): trying to fix * fix: 🔥 remove getServerSideProps 💥 also add 't' technology prefix * style(tech): remove css vendor prefix * feat(tech): reactivate buttons * refactor(tech): early bail out if * test(tech): remove unnecessary mock properties * refactor(tabs): use global row and cell * refactor(tech): early bail out if * fix(tech): mobile title responsivity * refactor(tech): rename section component * feat(error): define 400 as default error code * refactor(home): technologies as object of arrays * feat(tech): normalize taxonomies * test(tech): normalize taxonomies * refactor(tech): redirect to error page when not found * test(tech): redirect to 404 * chore(tech): remove unused prop * fix(card): redirect without refresh page resolves #328 * Quick fixces * Increasing timeouts * Updating snapshots * Adding a wait period before fetching last email Co-authored-by: Nícholas Oliveira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Description
Acceptance criteria
Implementation Brief
The text was updated successfully, but these errors were encountered: