Skip to content
This repository has been archived by the owner on Jan 22, 2019. It is now read-only.

Update to React 16 #57

Merged
merged 14 commits into from
Nov 16, 2017
Merged

Update to React 16 #57

merged 14 commits into from
Nov 16, 2017

Conversation

osk
Copy link
Contributor

@osk osk commented Sep 27, 2017

For this project, updating to React 16:

  • Bundle size ↓7.5%
  • Build time ↓5%
  • Hot code reload ↓7.5%

osk added 3 commits September 27, 2017 10:00
@osk
Fix bundle size check script
4c5619d
@osk
Update to React 16 🎉
73df4ab
@osk
Update dependencies
80ae3c5 
enzyme updated
enzyme-to-json updated
react-addons-test-utils deprecated
@birkir birkir temporarily deployed to starter-kit-universally-pr-57 September 27, 2017 10:19 Inactive
@osk osk temporarily deployed to starter-kit-universally-pr-57 September 27, 2017 10:36 Inactive
@osk osk temporarily deployed to starter-kit-universally-pr-57 September 27, 2017 11:54 Inactive
@osk
Copy link
Contributor Author

osk commented Sep 27, 2017

Some troubles with updating enzyme... removed check for SVG in <Header> to fix

@osk osk temporarily deployed to starter-kit-universally-pr-57 November 15, 2017 10:45 Inactive
@osk osk temporarily deployed to starter-kit-universally-pr-57 November 15, 2017 10:53 Inactive
@osk osk requested review from baldurh, finnursig and birkir and removed request for baldurh November 15, 2017 10:58
@baldurh baldurh temporarily deployed to starter-kit-universally-pr-57 November 16, 2017 11:41 Inactive
@baldurh baldurh temporarily deployed to starter-kit-universally-pr-57 November 16, 2017 13:07 Inactive
@baldurh
Adds jest:moduleFileExtensions
3d5bdb7 
Trying to get the tests running. See this thread:
enzymejs/enzyme#286 (comment)
@baldurh baldurh temporarily deployed to starter-kit-universally-pr-57 November 16, 2017 14:42 Inactive
@birkir birkir temporarily deployed to starter-kit-universally-pr-57 November 16, 2017 14:46 Inactive
@baldurh baldurh temporarily deployed to starter-kit-universally-pr-57 November 16, 2017 14:57 Inactive
baldurh
baldurh approved these changes Nov 16, 2017
View reviewed changes
Copy link
Contributor

@baldurh baldurh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried my best to get the tests to work but failed. That has nothing to do with this PR though so ...

@baldurh baldurh merged commit e9915fe into development Nov 16, 2017
@baldurh baldurh deleted the feature/react-16 branch November 16, 2017 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baldurh baldurh baldurh approved these changes

@finnursig finnursig Awaiting requested review from finnursig

@birkir birkir Awaiting requested review from birkir

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osk @baldurh @birkir