refactor(tiptap-extensions): Do not import the full lowlight
library.
#62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
CodeBlockHighlight
was importing the fulllowlight
libraries, including allsyntax highlighting definitions from
highlight.js
. The new behavior changes the signature ofCodeBlockHighlight
to accept an object with all syntax highlighting definitions. This means thatnow the user of the library MUST import languages themselves and tiptap will no longer
bundle the full
highlight.js
in itself.Testing:
npm run build
in the test repo and check if the highlight.js library is bundled with it.yarn build:packages
tiptap-extensions
to the test repo:npm run build
again on the rest repohighlight.js
anymore.Expected result:
This closes #16
[1] https://github.com/erickwilder/tiptap-treeshaking
[2] I had some issues with
npm link
and just to be quick I've copied the locally compiledtiptap-extensions
over the files installed vienpm install
in the test repo.