Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert type changes introduced with 2.10 #5859 #5860

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

nperez0111
Copy link
Contributor

Changes Overview

It seems that updating types is a catch-22 and I don't have the time to be resolving this, will reopen #5768 and let someone else implement this at another time

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: 2f401d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 2f401d4
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/674046ed77ab98000823bfc1
😎 Deploy Preview https://deploy-preview-5860--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nperez0111 nperez0111 changed the title fix: revert type changes introduced with 2.10 fix: revert type changes introduced with 2.10 #5859 Nov 22, 2024
@nperez0111 nperez0111 merged commit 9b1c66c into main Nov 22, 2024
14 checks passed
gethari pushed a commit to gethari/tiptap that referenced this pull request Nov 23, 2024
…osis#5860)

* revert: "fix(core): update the typings to be that options and storage are partials on an extended config ueberdosis#5852 (ueberdosis#5854)"

This reverts commit 87d63d8.

* revert: "fix(core): update the typing of `addOptions`, `addStorage` to have an optional parent ueberdosis#5768 (ueberdosis#5770)"

This reverts commit d2f366d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant