-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CharacterCount): Add counter function to CharacterCount
extension.
#5674
Conversation
🦋 Changeset detectedLatest commit: 2d0a255 The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
just a thought !
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea - LGTM
I think that a function gives the most flexibility to the end user on how they would want to implement this. Let's just go with this for now |
Changes Overview
Made
CharacterCount
's text and word counting logic to accessible from outside, which can solve issues with string containing emoji.Implementation Approach
I've just added these two options
and default options
Testing Done
Verification Steps
Additional Notes
Checklist
Related Issues