Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Return the invocation of command in order to get access to the return value in rendering component.
This allows one to act on it when for example doing an async action before updating the editor, like getting a suggestion from ChatGPT or fetching a response from an api to be inserted.
How did you accomplish your changes
return the invocation of
command
How have you tested your changes
In my own SlashMenu extension based on https://tiptap.dev/docs/editor/experiments/commands where I wanted to render a spinner if the item command function returned a promise.
How can we verify your changes
Return something from the items command function and check the value in the rendering component
Remarks
I didn't update the types of supported return value from the commands function, happy to get input on how to do that for increased type safety for supported return values
Checklist
Related issues