fix(history): use correct shortcuts for undo/redo #4435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
The problem with the shortcuts for undo/redo. the decision is made immediately for z/y.
I will use the abstract Ctrl-Shift-Z to avoid overlapping with tiptap.
I will describe for z:
Shift-Mod-Z doesn't make sense according to "Modifiers can be given in any order. Shift- (or s-), Alt- (or a-), Ctrl- (or c- or Control-) and Cmd- (or more Meta-) are recognized. For characters that are created by holding shift, the Shift- prefix is implied, and should not be added explicitly" prosemirror.
Only bindings with Shift are used for clarity.
How did you accomplish your changes
The solution is to set the correct commands and remove duplicate handlers
How have you tested your changes
tested locally. with stack length: 0, 1, 5
How can we verify your changes
open demo and see correct undo/redo behavior
Remarks
Checklist
Related issues
Fixes #4403