feat(placeholder): allow editor-is-empty class on any node #4335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR implements a new option for
@tiptap/extension-placeholder
that will allow users to enable more nodes than justparagraphs
as empty for theeditor-is-empty
empty check.How did you accomplish your changes
Instead of creating an empty doc copy, I'm directly checking the current document childCount, check if the first element is a valid node (as configured or is it not a atom or leaf) and then enable the class for valid nodes found at the first position of the editor.
How have you tested your changes
I used the local development environment for testing.
How can we verify your changes
considerAnyAsEmpty: true
Remarks
Checklist
Related issues