Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve introducing examples in the documentation #4334

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

lode
Copy link
Contributor

@lode lode commented Aug 16, 2023

Please describe your changes

This improves copy to introduce example code. Previously it added 'like that:'. In most cases this was just a stop word and can be removed. In other cases the sentence needs to be rewritten for that, or, what I did, replace it with 'like this:' because it refers to an upcoming example, instead of one that was shown before.

How did you accomplish your changes

n/a

How have you tested your changes

n/a

How can we verify your changes

I double checked my logic here: https://forum.wordreference.com/threads/like-this-like-that.2851037/

Remarks

n/a

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

This fixes #3747.

@lode lode requested a review from svenadlung as a code owner August 16, 2023 12:05
@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 6065f08
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/64dcbb936b7f160008be5f33
😎 Deploy Preview https://deploy-preview-4334--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'd be fine with those changes, what do you think @svenadlung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Mixing up the words 'that' and 'this'
3 participants