-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update splitListItem.ts to support overrideAttrs #4253
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This PR needs additional work to be merge-worthy. I hope someone will pickup and complete the remaining tasks as I will not have the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting and Typing issues I guess? Otherwise this looks fine, thank you.
I made these edits in a proper editor with ESLint support this time, so I think they should pass the tests. |
Although this commit still needs the associated docs update. |
LGTM for now – feel free to add docs to the PR |
bcaef5c
to
7e7ae19
Compare
🦋 Changeset detectedLatest commit: 1b96fc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Please describe your changes
This change addresses #4182
How did you accomplish your changes
Use object spread to allow
overrideAttrs
to override the default determined attributesHow have you tested your changes
Very minimally! I only tested these changes via
patch-package
and then free-handed them in using the online Github editorHow can we verify your changes
I have not added any relevant tests.
Remarks
I have not updated the docs
Checklist
Related issues
#4182