Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update splitListItem.ts to support overrideAttrs #4253

Merged
merged 4 commits into from
Aug 11, 2024

Conversation

Nantris
Copy link
Contributor

@Nantris Nantris commented Jul 26, 2023

Please describe your changes

This change addresses #4182

How did you accomplish your changes

Use object spread to allow overrideAttrs to override the default determined attributes

How have you tested your changes

Very minimally! I only tested these changes via patch-package and then free-handed them in using the online Github editor

How can we verify your changes

I have not added any relevant tests.

Remarks

I have not updated the docs

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

#4182

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 1b96fc4
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66b8fa35120a1d0008e59271
😎 Deploy Preview https://deploy-preview-4253--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nantris
Copy link
Contributor Author

Nantris commented Jul 26, 2023

This PR needs additional work to be merge-worthy. I hope someone will pickup and complete the remaining tasks as I will not have the time.

Copy link
Member

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting and Typing issues I guess? Otherwise this looks fine, thank you.

packages/core/src/commands/splitListItem.ts Outdated Show resolved Hide resolved
packages/core/src/commands/splitListItem.ts Show resolved Hide resolved
@bdbch bdbch self-assigned this Aug 4, 2023
@Nantris
Copy link
Contributor Author

Nantris commented Aug 9, 2023

I made these edits in a proper editor with ESLint support this time, so I think they should pass the tests.

@Nantris Nantris changed the title [WIP] Update splitListItem.ts to support overrideAttrs Update splitListItem.ts to support overrideAttrs Aug 9, 2023
@Nantris Nantris marked this pull request as ready for review August 9, 2023 19:58
@Nantris Nantris requested a review from svenadlung as a code owner August 9, 2023 19:58
@Nantris
Copy link
Contributor Author

Nantris commented Aug 9, 2023

Although this commit still needs the associated docs update.

@bdbch
Copy link
Member

bdbch commented Aug 11, 2023

LGTM for now – feel free to add docs to the PR

@nperez0111 nperez0111 force-pushed the develop branch 2 times, most recently from bcaef5c to 7e7ae19 Compare June 12, 2024 04:33
@bdbch bdbch deleted the branch ueberdosis:develop June 26, 2024 21:57
@bdbch bdbch closed this Jun 26, 2024
@bdbch bdbch reopened this Jun 27, 2024
Copy link

changeset-bot bot commented Aug 11, 2024

🦋 Changeset detected

Latest commit: 1b96fc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/core Major
@tiptap/extension-blockquote Major
@tiptap/extension-bold Major
@tiptap/extension-bubble-menu Major
@tiptap/extension-bullet-list Major
@tiptap/extension-character-count Major
@tiptap/extension-code-block-lowlight Major
@tiptap/extension-code-block Major
@tiptap/extension-code Major
@tiptap/extension-collaboration-cursor Major
@tiptap/extension-collaboration Major
@tiptap/extension-color Major
@tiptap/extension-document Major
@tiptap/extension-dropcursor Major
@tiptap/extension-floating-menu Major
@tiptap/extension-focus Major
@tiptap/extension-font-family Major
@tiptap/extension-gapcursor Major
@tiptap/extension-hard-break Major
@tiptap/extension-heading Major
@tiptap/extension-highlight Major
@tiptap/extension-history Major
@tiptap/extension-horizontal-rule Major
@tiptap/extension-image Major
@tiptap/extension-italic Major
@tiptap/extension-link Major
@tiptap/extension-list-item Major
@tiptap/extension-list-keymap Major
@tiptap/extension-mention Major
@tiptap/extension-ordered-list Major
@tiptap/extension-paragraph Major
@tiptap/extension-placeholder Major
@tiptap/extension-strike Major
@tiptap/extension-subscript Major
@tiptap/extension-superscript Major
@tiptap/extension-table-cell Major
@tiptap/extension-table-header Major
@tiptap/extension-table-row Major
@tiptap/extension-table Major
@tiptap/extension-task-item Major
@tiptap/extension-task-list Major
@tiptap/extension-text-align Major
@tiptap/extension-text-style Major
@tiptap/extension-text Major
@tiptap/extension-typography Major
@tiptap/extension-underline Major
@tiptap/extension-youtube Major
@tiptap/html Major
@tiptap/react Major
@tiptap/suggestion Major
@tiptap/vue-2 Major
@tiptap/vue-3 Major
@tiptap/starter-kit Major
@tiptap/pm Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nperez0111 nperez0111 merged commit 222f2ac into ueberdosis:develop Aug 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants