-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally delete full mention chip #3341
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ed3d0ca
to
fa18c09
Compare
@bdbch I worked w/ @Tommy-Sun to get this PR ready. Can you take a look and let us know if you have any comments? |
It would be really great if we could get this pull request merged! The functionality seems cool and useful @bdbch |
Documentation added! @bdbch |
Hi, just following up on this. Just need a review on the documentation I added! Would be great to use sooner rather than later. Thanks |
yeah @bdbch please review the documentation so everything can be merged in and we can use this feature :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. @svenadlung what do you think?
@Tommy-Sun we also have a conflict there. I'd like to merge this. If you find time, could you resolve this issue?
@Tommy-Sun any updates? |
Hi, not my best showing by any means but I finally came back around to this. Caught up the branch and inputted a change renaming |
@bdbch This should be good to go. |
What
Made available the option to delete the full mention chip as well as the suggestion char.
Changes
deleteOnBackspace
and defaulted it tofalse
.Why
Using Tiptap for a project our UX requirement was to remove the entire mention with only one backspace. This pull request also retains the original functionality by default.